[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Proof of concept patch for Wash Mode artifacts
From: Dmitry Kazakov <dimula73 () gmail ! com>
Date: 2013-06-18 7:55:34
Message-ID: CAEkBSfVE0yt5cxNzAcBGAJLS5GDRiyV_vxpV8kjzdgt7vVRDSw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi, Lukas!
Just checked: it doesn't fix that bug :( Looks like this is some other
problem.
On Mon, Jun 17, 2013 at 11:12 PM, Lukast dev <lukast.dev@gmail.com> wrote:
> Hi Dmitry,
>
> can you check if this fixes also this bug?
> https://bugs.kde.org/show_bug.cgi?id=300665
>
> Lukas
>
> 2013/6/16 Dmitry Kazakov <dimula73@gmail.com>:
> > Hi!
> >
> > One of the bugs I'm working on currently is Wash Mode bug, described by
> Paul
> > in the first part of the bug [0].
> >
> > Technical part:
> >
> > Actually, this is not a bug, but a flaw of the composition formula we
> use in
> > ALPHA_DARKEN composite op. So to fix this bug, we need to change the
> formula
> > (with all the obvious consequences). The problem is this formula is not
> > commutative, that is the order of application of dabs changes the result
> > dramatically.
> >
> > The patch:
> >
> > In the attachment you can find a patch which (should) fix this bug. It
> would
> > be nice if someone tested it and looked for some non-obvious regressions
> in
> > painting it introduces.
> >
> > This patch implements:
> > 1) Fixes the artifacts on the tail of the Wash Mode stroke
> >
> > This patch breaks (known issues):
> > 1) Flow option doesn't work (it is simply disabled)
> > 2) It fixes the bug for a Pixel Brush only
> > 3) It disables vector optimizations
> >
> >
> > [0] - https://bugs.kde.org/show_bug.cgi?id=320651
> >
> > --
> > Dmitry Kazakov
> > _______________________________________________
> > Krita mailing list
> > kimageshop@kde.org
> > https://mail.kde.org/mailman/listinfo/kimageshop
> >
> _______________________________________________
> Krita mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>
--
Dmitry Kazakov
[Attachment #5 (text/html)]
Hi, Lukas!<br><br>Just checked: it doesn't fix that bug :( Looks like this is \
some other problem.<br><br><div class="gmail_quote">On Mon, Jun 17, 2013 at 11:12 PM, \
Lukast dev <span dir="ltr"><<a href="mailto:lukast.dev@gmail.com" \
target="_blank">lukast.dev@gmail.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Dmitry,<br> <br>
can you check if this fixes also this bug?<br>
<a href="https://bugs.kde.org/show_bug.cgi?id=300665" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=300665</a><br> <br>
Lukas<br>
<br>
2013/6/16 Dmitry Kazakov <<a \
href="mailto:dimula73@gmail.com">dimula73@gmail.com</a>>:<br> <div><div \
class="h5">> Hi!<br> ><br>
> One of the bugs I'm working on currently is Wash Mode bug, described by \
Paul<br> > in the first part of the bug [0].<br>
><br>
> Technical part:<br>
><br>
> Actually, this is not a bug, but a flaw of the composition formula we use in<br>
> ALPHA_DARKEN composite op. So to fix this bug, we need to change the formula<br>
> (with all the obvious consequences). The problem is this formula is not<br>
> commutative, that is the order of application of dabs changes the result<br>
> dramatically.<br>
><br>
> The patch:<br>
><br>
> In the attachment you can find a patch which (should) fix this bug. It would<br>
> be nice if someone tested it and looked for some non-obvious regressions in<br>
> painting it introduces.<br>
><br>
> This patch implements:<br>
> 1) Fixes the artifacts on the tail of the Wash Mode stroke<br>
><br>
> This patch breaks (known issues):<br>
> 1) Flow option doesn't work (it is simply disabled)<br>
> 2) It fixes the bug for a Pixel Brush only<br>
> 3) It disables vector optimizations<br>
><br>
><br>
> [0] - <a href="https://bugs.kde.org/show_bug.cgi?id=320651" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=320651</a><br> ><br>
> --<br>
> Dmitry Kazakov<br>
</div></div>> _______________________________________________<br>
> Krita mailing list<br>
> <a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
> <a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> ><br>
_______________________________________________<br>
Krita mailing list<br>
<a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> \
</blockquote></div><br><br clear="all"><br>-- <br>Dmitry Kazakov
_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic