From kde-kimageshop  Tue Jun 18 07:55:34 2013
From: Dmitry Kazakov <dimula73 () gmail ! com>
Date: Tue, 18 Jun 2013 07:55:34 +0000
To: kde-kimageshop
Subject: Re: Proof of concept patch for Wash Mode artifacts
Message-Id: <CAEkBSfVE0yt5cxNzAcBGAJLS5GDRiyV_vxpV8kjzdgt7vVRDSw () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=137154214718014
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1614333280211554110=="

--===============1614333280211554110==
Content-Type: multipart/alternative; boundary=047d7b3a85a0b3ac0e04df690915

--047d7b3a85a0b3ac0e04df690915
Content-Type: text/plain; charset=UTF-8

Hi, Lukas!

Just checked: it doesn't fix that bug :( Looks like this is some other
problem.

On Mon, Jun 17, 2013 at 11:12 PM, Lukast dev <lukast.dev@gmail.com> wrote:

> Hi Dmitry,
>
> can you check if this fixes also this bug?
> https://bugs.kde.org/show_bug.cgi?id=300665
>
> Lukas
>
> 2013/6/16 Dmitry Kazakov <dimula73@gmail.com>:
> > Hi!
> >
> > One of the bugs I'm working on currently is Wash Mode bug, described by
> Paul
> > in the first part of the bug [0].
> >
> > Technical part:
> >
> > Actually, this is not a bug, but a flaw of the composition formula we
> use in
> > ALPHA_DARKEN composite op. So to fix this bug, we need to change the
> formula
> > (with all the obvious consequences). The problem is this formula is not
> > commutative, that is the order of application of dabs changes the result
> > dramatically.
> >
> > The patch:
> >
> > In the attachment you can find a patch which (should) fix this bug. It
> would
> > be nice if someone tested it and looked for some non-obvious regressions
> in
> > painting it introduces.
> >
> > This patch implements:
> > 1) Fixes the artifacts on the tail of the Wash Mode stroke
> >
> > This patch breaks (known issues):
> > 1) Flow option doesn't work (it is simply disabled)
> > 2) It fixes the bug for a Pixel Brush only
> > 3) It disables vector optimizations
> >
> >
> > [0] - https://bugs.kde.org/show_bug.cgi?id=320651
> >
> > --
> > Dmitry Kazakov
> > _______________________________________________
> > Krita mailing list
> > kimageshop@kde.org
> > https://mail.kde.org/mailman/listinfo/kimageshop
> >
> _______________________________________________
> Krita mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>



-- 
Dmitry Kazakov

--047d7b3a85a0b3ac0e04df690915
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi, Lukas!<br><br>Just checked: it doesn&#39;t fix that bug :( Looks like t=
his is some other problem.<br><br><div class=3D"gmail_quote">On Mon, Jun 17=
, 2013 at 11:12 PM, Lukast dev <span dir=3D"ltr">&lt;<a href=3D"mailto:luka=
st.dev@gmail.com" target=3D"_blank">lukast.dev@gmail.com</a>&gt;</span> wro=
te:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">Hi Dmitry,<br>
<br>
can you check if this fixes also this bug?<br>
<a href=3D"https://bugs.kde.org/show_bug.cgi?id=3D300665" target=3D"_blank"=
>https://bugs.kde.org/show_bug.cgi?id=3D300665</a><br>
<br>
Lukas<br>
<br>
2013/6/16 Dmitry Kazakov &lt;<a href=3D"mailto:dimula73@gmail.com">dimula73=
@gmail.com</a>&gt;:<br>
<div><div class=3D"h5">&gt; Hi!<br>
&gt;<br>
&gt; One of the bugs I&#39;m working on currently is Wash Mode bug, describ=
ed by Paul<br>
&gt; in the first part of the bug [0].<br>
&gt;<br>
&gt; Technical part:<br>
&gt;<br>
&gt; Actually, this is not a bug, but a flaw of the composition formula we =
use in<br>
&gt; ALPHA_DARKEN composite op. So to fix this bug, we need to change the f=
ormula<br>
&gt; (with all the obvious consequences). The problem is this formula is no=
t<br>
&gt; commutative, that is the order of application of dabs changes the resu=
lt<br>
&gt; dramatically.<br>
&gt;<br>
&gt; The patch:<br>
&gt;<br>
&gt; In the attachment you can find a patch which (should) fix this bug. It=
 would<br>
&gt; be nice if someone tested it and looked for some non-obvious regressio=
ns in<br>
&gt; painting it introduces.<br>
&gt;<br>
&gt; This patch implements:<br>
&gt; 1) Fixes the artifacts on the tail of the Wash Mode stroke<br>
&gt;<br>
&gt; This patch breaks (known issues):<br>
&gt; 1) Flow option doesn&#39;t work (it is simply disabled)<br>
&gt; 2) It fixes the bug for a Pixel Brush only<br>
&gt; 3) It disables vector optimizations<br>
&gt;<br>
&gt;<br>
&gt; [0] - <a href=3D"https://bugs.kde.org/show_bug.cgi?id=3D320651" target=
=3D"_blank">https://bugs.kde.org/show_bug.cgi?id=3D320651</a><br>
&gt;<br>
&gt; --<br>
&gt; Dmitry Kazakov<br>
</div></div>&gt; _______________________________________________<br>
&gt; Krita mailing list<br>
&gt; <a href=3D"mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
&gt; <a href=3D"https://mail.kde.org/mailman/listinfo/kimageshop" target=3D=
"_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br>
&gt;<br>
_______________________________________________<br>
Krita mailing list<br>
<a href=3D"mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
<a href=3D"https://mail.kde.org/mailman/listinfo/kimageshop" target=3D"_bla=
nk">https://mail.kde.org/mailman/listinfo/kimageshop</a><br>
</blockquote></div><br><br clear=3D"all"><br>-- <br>Dmitry Kazakov

--047d7b3a85a0b3ac0e04df690915--

--===============1614333280211554110==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop

--===============1614333280211554110==--