[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Grayscale Selections
From:       Sven Langkamp <sven.langkamp () gmail ! com>
Date:       2011-07-18 1:40:11
Message-ID: CAAmsBfnKe8A=N0U-wjGgvt=SfrJeckV2KDFFsO4s7KYe8wBTyA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sun, Jul 17, 2011 at 9:09 AM, Cyrille Berger Skott
<cberger@cberger.net>wrote:

> On Sunday 17 July 2011, Sven Langkamp wrote:
> > On Sat, Jul 16, 2011 at 10:17 PM, Sven Langkamp
> <sven.langkamp@gmail.com>wrote:
> > > On Sat, Jul 16, 2011 at 10:06 PM, Cyrille Berger Skott <
> > > Hmm I somehow saved the wrong diff and reverted the other code :/
> > >
> > > I also tried the params method. That was called by the result was
> exactly
> > > the same as when I didn't overwrite anything.
> >
> > Correction. Right code after all. I checked and at least the method is
> > called, but does nothing.
>
> Maybe you can write a unit test ? It should not be too difficult to create
> some
> small buffers that exhibits the result you want, and then if the unit test
> fails, I can have a look.
>

I have added a unit test (KisPainterTest::testBltToSelection). It does
bitBlt a black rect on a selection and check if that area is MIN_SELECTED.

[Attachment #5 (text/html)]

<div class="gmail_quote">On Sun, Jul 17, 2011 at 9:09 AM, Cyrille Berger Skott <span \
dir="ltr">&lt;<a href="mailto:cberger@cberger.net">cberger@cberger.net</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> <div class="im">On Sunday 17 July 2011, Sven Langkamp \
wrote:<br> &gt; On Sat, Jul 16, 2011 at 10:17 PM, Sven Langkamp<br>
&lt;<a href="mailto:sven.langkamp@gmail.com">sven.langkamp@gmail.com</a>&gt;wrote:<br>
 &gt; &gt; On Sat, Jul 16, 2011 at 10:06 PM, Cyrille Berger Skott &lt;<br>
</div><div class="im">&gt; &gt; Hmm I somehow saved the wrong diff and reverted the \
other code :/<br> &gt; &gt;<br>
&gt; &gt; I also tried the params method. That was called by the result was \
exactly<br> &gt; &gt; the same as when I didn&#39;t overwrite anything.<br>
&gt;<br>
&gt; Correction. Right code after all. I checked and at least the method is<br>
&gt; called, but does nothing.<br>
<br>
</div>Maybe you can write a unit test ? It should not be too difficult to create \
some<br> small buffers that exhibits the result you want, and then if the unit \
test<br> fails, I can have a look.<br></blockquote><div><br>I have added a unit test \
(KisPainterTest::testBltToSelection). It does bitBlt a black rect on a selection and \
check if that area is MIN_SELECTED. <br></div></div>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]