From kde-kimageshop Mon Jul 18 01:40:11 2011 From: Sven Langkamp Date: Mon, 18 Jul 2011 01:40:11 +0000 To: kde-kimageshop Subject: Re: Grayscale Selections Message-Id: X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=131095325229969 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1389074411==" --===============1389074411== Content-Type: multipart/alternative; boundary=0016364edbc07fd8c204a84e1417 --0016364edbc07fd8c204a84e1417 Content-Type: text/plain; charset=ISO-8859-1 On Sun, Jul 17, 2011 at 9:09 AM, Cyrille Berger Skott wrote: > On Sunday 17 July 2011, Sven Langkamp wrote: > > On Sat, Jul 16, 2011 at 10:17 PM, Sven Langkamp > wrote: > > > On Sat, Jul 16, 2011 at 10:06 PM, Cyrille Berger Skott < > > > Hmm I somehow saved the wrong diff and reverted the other code :/ > > > > > > I also tried the params method. That was called by the result was > exactly > > > the same as when I didn't overwrite anything. > > > > Correction. Right code after all. I checked and at least the method is > > called, but does nothing. > > Maybe you can write a unit test ? It should not be too difficult to create > some > small buffers that exhibits the result you want, and then if the unit test > fails, I can have a look. > I have added a unit test (KisPainterTest::testBltToSelection). It does bitBlt a black rect on a selection and check if that area is MIN_SELECTED. --0016364edbc07fd8c204a84e1417 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Sun, Jul 17, 2011 at 9:09 AM, Cyrille Berger = Skott <cberger@= cberger.net> wrote:
On Sunday 17 July 2011, Sven Langkamp wrote:
> On Sat, Jul 16, 2011 at 10:17 PM, Sven Langkamp
<sven.langkamp@gmail.com&= gt;wrote:
> > On Sat, Jul 16, 2011 at 10:06 PM, Cyrille Berger Skott <
> > Hmm I somehow saved the wrong diff and re= verted the other code :/
> >
> > I also tried the params method. That was called by the result was= exactly
> > the same as when I didn't overwrite anything.
>
> Correction. Right code after all. I checked and at least the method is=
> called, but does nothing.

Maybe you can write a unit test ? It should not be too difficult to c= reate some
small buffers that exhibits the result you want, and then if the unit test<= br> fails, I can have a look.

I have added a unit test= (KisPainterTest::testBltToSelection). It does bitBlt a black rect on a sel= ection and check if that area is MIN_SELECTED.
--0016364edbc07fd8c204a84e1417-- --===============1389074411== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kimageshop mailing list kimageshop@kde.org https://mail.kde.org/mailman/listinfo/kimageshop --===============1389074411==--