[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Branch: krita-canvasrotation-silvioheinrich
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2011-02-01 22:00:54
Message-ID: 201102012300.54183.boud () valdyas ! org
[Download RAW message or body]

On Tuesday 01 February 2011, Silvio Heinrich wrote:
> I fixed the canvas rotation and tried to improve the zooming.
> The image was shifting away while rotating it. This should not happen 
> anymore.
> I also moved the focus of the zoom to the middle of the canvas widget.
> I done this because when painting you normally center the area you are 
> currently painting on
> at the middle of the view.

Well... zooming really must always be around the cursor, if zooming with mouse wheel \
or ctrl-plus/minus (ask animtim, he is very outspoken about that!). When zooming with \
the statusbar controls, it should be around the center of the screen, or perhaps the \
last place where we painted.

> The image will not shift away anymore while zooming in and out (what is 
> in the middle should stay in the middle).
> 
> To the KisCoordinatesConverter class:
> It looked a bit hacky to me so i tried to clean it up.
> I did major modifications to this class and since it was (as far as i 
> know) entirely created by
> Dimitry Kazakov it would be nice if he could have a look at it and would 
> tell me if he agrees
> with the modifications.
> 
> It would of course be nice too, if other people could try out the branch 
> and tell me if those modifications
> did introduce some problems or regressions.
> 
> thx :)
> 


-- 
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]