'Branch: krita-canvasrotation-silvioheinrich'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Branch: krita-canvasrotation-silvioheinrich
From:       Silvio Heinrich <plassy () web ! de>
Date:       2011-02-01 20:43:37
Message-ID: 4D487079.7040009 () web ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

I fixed the canvas rotation and tried to improve the zooming.
The image was shifting away while rotating it. This should not happen 
anymore.
I also moved the focus of the zoom to the middle of the canvas widget.
I done this because when painting you normally center the area you are 
currently painting on
at the middle of the view.
The image will not shift away anymore while zooming in and out (what is 
in the middle should stay in the middle).

To the KisCoordinatesConverter class:
It looked a bit hacky to me so i tried to clean it up.
I did major modifications to this class and since it was (as far as i 
know) entirely created by
Dimitry Kazakov it would be nice if he could have a look at it and would 
tell me if he agrees
with the modifications.

It would of course be nice too, if other people could try out the branch 
and tell me if those modifications
did introduce some problems or regressions.

thx :)

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
  </head>
  <body bgcolor="#ffffff" text="#000000">
    I fixed the canvas rotation and tried to improve the zooming.<br>
    The image was shifting away while rotating it. This should not
    happen anymore.<br>
    I also moved the focus of the zoom to the middle of the canvas
    widget.<br>
    I done this because when painting you normally center the area you
    are currently painting on <br>
    at the middle of the view.<br>
    The image will not shift away anymore while zooming in and out (what
    is in the middle should stay in the middle).<br>
    <br>
    To the KisCoordinatesConverter class:<br>
    It looked a bit hacky to me so i tried to clean it up.<br>
    I did major modifications to this class and since it was (as far as
    i know) entirely created by <br>
    Dimitry Kazakov
    <style type="text/css">p, li { white-space: pre-wrap; }</style>
    it would be nice if he could have a look at it and would tell me if
    he agrees<br>
    with the modifications.<br>
    <br>
    It would of course be nice too, if other people could try out the
    branch and tell me if those modifications<br>
    did introduce some problems or regressions.<br>
    <br>
    thx :)<br>
    <span style="font-family: 'Courier New,courier'; font-style: italic;
      color: rgb(154, 25, 0);"></span>
  </body>
</html>

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop

[prev in list] [next in list] [prev in thread] [next in thread] 