[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Patches: Fix of smudge brush and a few other small things (sorry
From:       Cyrille Berger Skott <cberger () cberger ! net>
Date:       2011-01-01 9:27:27
Message-ID: 201101011027.27919.cberger () cberger ! net
[Download RAW message or body]

Hi,

I did some testing. First, I needed the attached patch to make it build. I 
also did not get a good results as can be seen in:
http://cyrille.diwi.org/tmp/krita/smudgebrush/blackfringe.png

I get those dark fringe. It also does not work nicely when when starting from 
the brush.

As for the cross hair, it is a good idea, however it is slightly off, you can 
see that by creating a big brush and then zooming out a lot (I wanted to make 
a screenshot, but ksnapshot does not capture the cursor :( ).

-- 
Cyrille Berger Skott

["0001-fix-compilation.patch" (text/x-patch)]

From 1dbcf2d2121c4124612e6b29b07fce655018d014 Mon Sep 17 00:00:00 2001
From: Cyrille Berger <cberger@cberger.net>
Date: Sat, 1 Jan 2011 10:03:32 +0100
Subject: [PATCH] fix compilation

---
 .../libpaintop/kis_pressure_composite_option.cpp   |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/krita/plugins/paintops/libpaintop/kis_pressure_composite_option.cpp \
b/krita/plugins/paintops/libpaintop/kis_pressure_composite_option.cpp index \
                ca09eb6..baed22a 100644
--- a/krita/plugins/paintops/libpaintop/kis_pressure_composite_option.cpp
+++ b/krita/plugins/paintops/libpaintop/kis_pressure_composite_option.cpp
@@ -56,7 +56,7 @@ void KisPressureCompositeOption::readOptionSetting(const \
KisPropertiesConfigurat  void KisPressureCompositeOption::apply(KisPainter* painter, \
qint8 opacity, const KisPaintInformation& info) const  {
     if(!isChecked())
-        return painter->compositeOp()->id();
+        return;
     
     QString oldCompositeOp = painter->compositeOp()->id();
     
@@ -68,6 +68,6 @@ void KisPressureCompositeOption::apply(KisPainter* painter, qint8 \
opacity, const  painter->setCompositeOp(m_compositeOp);
     painter->setOpacity(opacity);
 
-    return oldCompositeOp;
+    return;
 }
 
-- 
1.7.2.3



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]