From kde-kimageshop Sat Jan 01 09:27:27 2011 From: Cyrille Berger Skott Date: Sat, 01 Jan 2011 09:27:27 +0000 To: kde-kimageshop Subject: Re: Patches: Fix of smudge brush and a few other small things (sorry Message-Id: <201101011027.27919.cberger () cberger ! net> X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=129387411219739 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--Boundary-00=_/NvHNS74kS4nvid" --Boundary-00=_/NvHNS74kS4nvid Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Hi, I did some testing. First, I needed the attached patch to make it build. I also did not get a good results as can be seen in: http://cyrille.diwi.org/tmp/krita/smudgebrush/blackfringe.png I get those dark fringe. It also does not work nicely when when starting from the brush. As for the cross hair, it is a good idea, however it is slightly off, you can see that by creating a big brush and then zooming out a lot (I wanted to make a screenshot, but ksnapshot does not capture the cursor :( ). -- Cyrille Berger Skott --Boundary-00=_/NvHNS74kS4nvid Content-Type: text/x-patch; charset="UTF-8"; name="0001-fix-compilation.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-fix-compilation.patch" =46rom 1dbcf2d2121c4124612e6b29b07fce655018d014 Mon Sep 17 00:00:00 2001 =46rom: Cyrille Berger Date: Sat, 1 Jan 2011 10:03:32 +0100 Subject: [PATCH] fix compilation =2D-- .../libpaintop/kis_pressure_composite_option.cpp | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/krita/plugins/paintops/libpaintop/kis_pressure_composite_optio= n.cpp b/krita/plugins/paintops/libpaintop/kis_pressure_composite_option.cpp index ca09eb6..baed22a 100644 =2D-- a/krita/plugins/paintops/libpaintop/kis_pressure_composite_option.cpp +++ b/krita/plugins/paintops/libpaintop/kis_pressure_composite_option.cpp @@ -56,7 +56,7 @@ void KisPressureCompositeOption::readOptionSetting(const = KisPropertiesConfigurat void KisPressureCompositeOption::apply(KisPainter* painter, qint8 opacity,= const KisPaintInformation& info) const { if(!isChecked()) =2D return painter->compositeOp()->id(); + return; =20 QString oldCompositeOp =3D painter->compositeOp()->id(); =20 @@ -68,6 +68,6 @@ void KisPressureCompositeOption::apply(KisPainter* painte= r, qint8 opacity, const painter->setCompositeOp(m_compositeOp); painter->setOpacity(opacity); =20 =2D return oldCompositeOp; + return; } =20 =2D-=20 1.7.2.3 --Boundary-00=_/NvHNS74kS4nvid Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kimageshop mailing list kimageshop@kde.org https://mail.kde.org/mailman/listinfo/kimageshop --Boundary-00=_/NvHNS74kS4nvid--