[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Tool overlay and cursor shapes
From:       Cyrille Berger <cberger () cberger ! net>
Date:       2009-09-04 8:52:20
Message-ID: 200909041052.21493.cberger () cberger ! net
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,

On Friday 04 September 2009, LukasT.dev@gmail.com wrote:
> I'm waiting whether somebody approve my commit which uses QImage as buffer
> in canvas although we have many buffers in the render chain...
That is still a concern.

> At least my
> patch would help me to fix some issues (I could use various compositing
> modes, e.g. XOR, without fear that some platform or X11 would not work
> correctly)
What's wrong with the black&white lines solution ?

> Related bugs:
> * When you change the cursor shape in Krita, it is changed after you change
> the tool from freehand to some other tool and back to freehand.
>
> * Brush outlines are invisible on black surfaces. Solution is composition
> mode ala XOR or black-and-white outline of the tool. This was discussed on
> IRC with boemann and Cyrille and I tested various approaches for this so
> just document your opinion here please.
I wonder if a solution to that wouldn't be to use the current color for the 
brush outline.

> I would prefer some intelligent XOR instead of black&white versions. When
> the under-laying pixel has brightness less then 50 use black pixel, white
> otherwise...
Yes but we don't have that in Qt, do we ?

-- 
Cyrille Berger

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" \
content="1" /><style type="text/css">p, li { white-space: pre-wrap; \
}</style></head><body style=" font-family:'DejaVu Sans'; font-size:9pt; \
font-weight:400; font-style:normal;">Hi,<br> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>On Friday 04 \
September 2009, LukasT.dev@gmail.com wrote:<br> &gt; I'm waiting whether somebody \
approve my commit which uses QImage as buffer<br> &gt; in canvas although we have \
many buffers in the render chain...<br> That is still a concern.<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>&gt; At least my<br> &gt; patch would help me to fix some \
issues (I could use various compositing<br> &gt; modes, e.g. XOR, without fear that \
some platform or X11 would not work<br> &gt; correctly)<br>
What's wrong with the black&amp;white lines solution ?<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>&gt; Related bugs:<br> &gt; * When you change the cursor \
shape in Krita, it is changed after you change<br> &gt; the tool from freehand to \
some other tool and back to freehand.<br> &gt;<br>
&gt; * Brush outlines are invisible on black surfaces. Solution is composition<br>
&gt; mode ala XOR or black-and-white outline of the tool. This was discussed on<br>
&gt; IRC with boemann and Cyrille and I tested various approaches for this so<br>
&gt; just document your opinion here please.<br>
I wonder if a solution to that wouldn't be to use the current color for the brush \
outline.<br> <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>&gt; I would prefer some intelligent XOR instead of \
black&amp;white versions. When<br> &gt; the under-laying pixel has brightness less \
then 50 use black pixel, white<br> &gt; otherwise...<br>
Yes but we don't have that in Qt, do we ?<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>-- <br> Cyrille Berger</p></body></html>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic