[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: exactBounds
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2007-07-23 7:15:56
Message-ID: 200707230915.56408.boud () valdyas ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 18 July 2007, Casper Boemann wrote:
> On Wednesday 18 July 2007 17:56, Sven Langkamp wrote:
> > > for the selection it's ok to check against SELECT_MIN etc
> > >
> > > it's only for normal colorspaces that it is not possible
> >
> > Unfortunatly bltMask gets a normal KisPaintDevice as mask, which make
> > it impossible to determine if defaultpixel can be treated like
> > SELECT_MIN
>
> uh, that sounds wrong - we should get a selection as mask - and if this is
> something boudewijn has changed recently then we should try to get a better
> solution that also ssatisfies him

I did touch the bltMask code a bit to fix some bugs for Sven, but didn't 
change the method signature: it already took a KisPaintDeviceSP as selMask 
param in 1.x. So I'm open for any solution that makes all unittests work 
again :-)

By the way, I feel that the add/subtract/intersect/clearSelection methods 
don't really belong in the KisPaintDevice api, but should be part of 
KisSelection or KisPixelSelection. 

-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi

["signature.asc" (application/pgp-signature)]

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]