--===============0677710671== Content-Type: multipart/signed; boundary="nextPart2762027.jvgdgyys5C"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart2762027.jvgdgyys5C Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 18 July 2007, Casper Boemann wrote: > On Wednesday 18 July 2007 17:56, Sven Langkamp wrote: > > > for the selection it's ok to check against SELECT_MIN etc > > > > > > it's only for normal colorspaces that it is not possible > > > > Unfortunatly bltMask gets a normal KisPaintDevice as mask, which make > > it impossible to determine if defaultpixel can be treated like > > SELECT_MIN > > uh, that sounds wrong - we should get a selection as mask - and if this is > something boudewijn has changed recently then we should try to get a bett= er > solution that also ssatisfies him I did touch the bltMask code a bit to fix some bugs for Sven, but didn't=20 change the method signature: it already took a KisPaintDeviceSP as selMask= =20 param in 1.x. So I'm open for any solution that makes all unittests work=20 again :-) By the way, I feel that the add/subtract/intersect/clearSelection methods=20 don't really belong in the KisPaintDevice api, but should be part of=20 KisSelection or KisPixelSelection.=20 =2D-=20 Boudewijn Rempt=20 http://www.valdyas.org/fading/index.cgi --nextPart2762027.jvgdgyys5C Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBGpFWsdaCcgCmN5d8RApd5AKCNM+m6mPALrgF0aJyj35vg8UnxkQCfWckJ qxUrmw92WT9z1AfY5oF1kVM= =RdVw -----END PGP SIGNATURE----- --nextPart2762027.jvgdgyys5C-- --===============0677710671== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kimageshop mailing list kimageshop@kde.org https://mail.kde.org/mailman/listinfo/kimageshop --===============0677710671==--