[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Fwd: [Bug 135165] Rotating an imported NEF (Nikon RAW) image
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2006-10-05 20:02:44
Message-ID: 200610052202.46436.boud () valdyas ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Just a question related to the solution to this bug -- perhaps someone on the 
list knows the answer...

* Why do we have to open the source iterator writable?
-            KisHLineIteratorPixel srcIt = src->createHLineIterator(r.x(), y, 
r.width(), false);
+            KisHLineIteratorPixel srcIt = src->createHLineIterator(r.x(), y, 
r.width(), true);

* Why do we try to set the alpha channel of the source paint device?

data = srcIt.rawData();
// XXX: Should set alpha = alpha*(1-selectedness)
cs->setAlpha(data, 0, 1);

Cyrille, Bart and me, we're all baffled as bathroom geysers, although pretty 
elated that this bug has been solved in time for 1.6.
-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi

["forwarded message" (message/rfc822)]

Return-Path: <bugzilla@ktown.kde.org>
X-Original-To: boud@valdyas.org
Delivered-To: boud@valdyas.org
Received: by calcifer.valdyas.org (Postfix, from userid 65534)
	id 5C16EBEFCE; Thu,  5 Oct 2006 21:51:56 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on 
	calcifer.valdyas.org
X-Spam-Level: *
X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,SUBJ_ILLEGAL
_CHARS 
	autolearn=no version=3.1.3
Received: from ktown.kde.org (unknown [131.246.120.250])
	by calcifer.valdyas.org (Postfix) with SMTP id 0BBA3BEFC8
	for <boud@valdyas.org>; Thu,  5 Oct 2006 19:51:56 +0000 (UTC)
Received: (qmail 4805 invoked by uid 1109); 5 Oct 2006 19:51:44 -0000
Date: 5 Oct 2006 19:51:44 -0000
Message-ID: <20061005195144.4804.qmail@ktown.kde.org>
From: Cyrille Berger <cyb@lepi.org>
To: boud@valdyas.org
Sender: owner@bugs.kde.org
Reply-To: 135165@bugs.kde.org
Subject: [Bug 135165] Rotating an imported NEF (Nikon RAW) image 180 ° produces empty \
                area, undoing produces empty image   
Content-Type: text/plain;
  charset="utf-8"
X-Bugzilla-URL: http://bugs.kde.org/   
X-Bugzilla-Reason: AssignedTo   
Precedence: bulk 
In-Reply-To: <20061005201715.135165.rgc@rgc.be>  

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=135165         
cyb lepi org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From cyb lepi org  2006-10-05 21:51 -------
SVN commit 592798 by berger:

fix undo of rotate 180
BUG:135165


 M  +4 -5      kis_transform_worker.cc  


--- branches/koffice/1.6/koffice/krita/core/kis_transform_worker.cc #592797:592798
 @ -146,7 +146,7  @
     }
 
     for (Q_INT32 y = r.top(); y <= r.bottom(); ++y) {
-        KisHLineIteratorPixel srcIt = src->createHLineIterator(r.x(), y, r.width(), \
false); +        KisHLineIteratorPixel srcIt = src->createHLineIterator(r.x(), y, \
                r.width(), true);
         KisHLineIterator dstIt = dst->createHLineIterator(-r.x() - r.width(), -y, \
                r.width(), true);
         KisHLineIterator dstSelIt = dstSelection->createHLineIterator(-r.x() - \
r.width(), -y, r.width(), true);  
 @ -264,7 +264,7  @
         dstLen = scale;
 
     // Calculate extra length (in each side) needed due to shear
-    Q_INT32 extraLen = (support+256)>>8;
+    Q_INT32 extraLen = (support+256)>>8 + 1;
 
     Q_UINT8 *tmpLine = new Q_UINT8[(srcLen +2*extraLen)* pixelSize];
     Q_CHECK_PTR(tmpLine);
 @ -344,14 +344,13  @
         {
             Q_UINT8 *data;
 
-            if(srcIt.isSelected())
-            {
                 data = srcIt.rawData();
                 memcpy(&tmpLine[i*pixelSize], data, pixelSize);
 
                 // XXX: Should set alpha = alpha*(1-selectedness)
                 cs->setAlpha(data, 0, 1);
-
+            if(srcIt.isSelected())
+            {
                 tmpSel[i] = 255;
             }
             else


[Attachment #8 (application/pgp-signature)]

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]