From kde-kimageshop Thu Oct 05 20:02:44 2006 From: Boudewijn Rempt Date: Thu, 05 Oct 2006 20:02:44 +0000 To: kde-kimageshop Subject: Fwd: [Bug 135165] Rotating an imported NEF (Nikon RAW) image Message-Id: <200610052202.46436.boud () valdyas ! org> X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=116007862517677 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0330707433==" --===============0330707433== Content-Type: multipart/signed; boundary="nextPart1188066.und94Ifc0M"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart1188066.und94Ifc0M Content-Type: multipart/mixed; boundary="Boundary-01=_kTWJF42KdslO+Nn" Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-01=_kTWJF42KdslO+Nn Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Just a question related to the solution to this bug -- perhaps someone on t= he=20 list knows the answer... * Why do we have to open the source iterator writable? =2D =C2=A0 =C2=A0 =C2=A0 =C2=A0KisHLineIteratorPixel srcIt =3D src->createH= LineIterator(r.x(), y,=20 r.width(), false); + =C2=A0 =C2=A0 =C2=A0 =C2=A0KisHLineIteratorPixel srcIt =3D src->createHLi= neIterator(r.x(), y,=20 r.width(), true); * Why do we try to set the alpha channel of the source paint device? data =3D srcIt.rawData(); // XXX: Should set alpha =3D alpha*(1-selectedness) cs->setAlpha(data, 0, 1); Cyrille, Bart and me, we're all baffled as bathroom geysers, although prett= y=20 elated that this bug has been solved in time for 1.6. =2D-=20 Boudewijn Rempt=20 http://www.valdyas.org/fading/index.cgi --Boundary-01=_kTWJF42KdslO+Nn Content-Type: message/rfc822; name="forwarded message" Content-Transfer-Encoding: quoted-printable Content-Description: Cyrille Berger : [Bug 135165] Rotating an imported NEF (Nikon RAW) image =?utf-8?q?180=C3=82=C2=B0_produces_empty?= area, undoing produces empty image Content-Disposition: inline Return-Path: X-Original-To: boud@valdyas.org Delivered-To: boud@valdyas.org Received: by calcifer.valdyas.org (Postfix, from userid 65534) id 5C16EBEFCE; Thu, 5 Oct 2006 21:51:56 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on=20 calcifer.valdyas.org X-Spam-Level: * X-Spam-Status: No, score=3D1.7 required=3D5.0 tests=3DBAYES_00,SUBJ_ILLEGAL= _CHARS=20 autolearn=3Dno version=3D3.1.3 Received: from ktown.kde.org (unknown [131.246.120.250]) by calcifer.valdyas.org (Postfix) with SMTP id 0BBA3BEFC8 for ; Thu, 5 Oct 2006 19:51:56 +0000 (UTC) Received: (qmail 4805 invoked by uid 1109); 5 Oct 2006 19:51:44 -0000 Date: 5 Oct 2006 19:51:44 -0000 Message-ID: <20061005195144.4804.qmail@ktown.kde.org> =46rom: Cyrille Berger To: boud@valdyas.org Sender: owner@bugs.kde.org Reply-To: 135165@bugs.kde.org Subject: [Bug 135165] Rotating an imported NEF (Nikon RAW) image 180=C2=B0 = produces empty area, undoing produces empty image =20 Content-Type: text/plain; charset=3D"utf-8" X-Bugzilla-URL: http://bugs.kde.org/ =20 X-Bugzilla-Reason: AssignedTo =20 Precedence: bulk=20 In-Reply-To: <20061005201715.135165.rgc@rgc.be> =20 =2D------ You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. =20 http://bugs.kde.org/show_bug.cgi?id=3D135165 =20 cyb lepi org changed: What |Removed |Added =2D------------------------------------------------------------------------= =2D-- Status|NEW |RESOLVED Resolution| |FIXED =2D------ Additional Comments From cyb lepi org 2006-10-05 21:51 ------- SVN commit 592798 by berger: fix undo of rotate 180 BUG:135165 M +4 -5 kis_transform_worker.cc =20 =2D-- branches/koffice/1.6/koffice/krita/core/kis_transform_worker.cc #5927= 97:592798 @ -146,7 +146,7 @ } =20 for (Q_INT32 y =3D r.top(); y <=3D r.bottom(); ++y) { =2D KisHLineIteratorPixel srcIt =3D src->createHLineIterator(r.x(), = y, r.width(), false); + KisHLineIteratorPixel srcIt =3D src->createHLineIterator(r.x(), y,= r.width(), true); KisHLineIterator dstIt =3D dst->createHLineIterator(-r.x() - r.wid= th(), -y, r.width(), true); KisHLineIterator dstSelIt =3D dstSelection->createHLineIterator(-r= =2Ex() - r.width(), -y, r.width(), true); =20 @ -264,7 +264,7 @ dstLen =3D scale; =20 // Calculate extra length (in each side) needed due to shear =2D Q_INT32 extraLen =3D (support+256)>>8; + Q_INT32 extraLen =3D (support+256)>>8 + 1; =20 Q_UINT8 *tmpLine =3D new Q_UINT8[(srcLen +2*extraLen)* pixelSize]; Q_CHECK_PTR(tmpLine); @ -344,14 +344,13 @ { Q_UINT8 *data; =20 =2D if(srcIt.isSelected()) =2D { data =3D srcIt.rawData(); memcpy(&tmpLine[i*pixelSize], data, pixelSize); =20 // XXX: Should set alpha =3D alpha*(1-selectedness) cs->setAlpha(data, 0, 1); =2D + if(srcIt.isSelected()) + { tmpSel[i] =3D 255; } else --Boundary-01=_kTWJF42KdslO+Nn-- --nextPart1188066.und94Ifc0M Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) iD8DBQBFJWTmdaCcgCmN5d8RAsq/AJ9OHsATbGc0QFaui3gW4+vBy0JIHQCfXkQC Jt+OrFDUWyr3hW/0LAP1yCc= =ITUB -----END PGP SIGNATURE----- --nextPart1188066.und94Ifc0M-- --===============0330707433== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kimageshop mailing list kimageshop@kde.org https://mail.kde.org/mailman/listinfo/kimageshop --===============0330707433==--