[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    [dolphin/release/19.12] src: Fix accessibility regression on the Dolphin Control button
From:       Elvis Angelaccio <null () kde ! org>
Date:       2019-11-24 18:13:39
Message-ID: E1iYwOB-0003Ku-KL () code ! kde ! org
[Download RAW message or body]

Git commit 82e366f024cb47106f0195e53f97c5beea2e798a by Elvis Angelaccio.
Committed on 24/11/2019 at 18:06.
Pushed by elvisangelaccio into branch 'release/19.12'.

Fix accessibility regression on the Dolphin Control button

9cd042a86c removed the text from the Control button without setting an
accessibleName property, which is a regression for screen-reader users.

This breaks the 19.12 string freeze, but since it's the same string we
were translating before 9cd042a86c, hopefully it's not going to be too
much of a burden for translators.

CCBUG: 414271
CCMAIL: kde-i18n-doc@kde.org

M  +1    -0    src/dolphinmainwindow.cpp

https://commits.kde.org/dolphin/82e366f024cb47106f0195e53f97c5beea2e798a

diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index e28b18cd3d..56ea93e104 100644
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -1880,6 +1880,7 @@ void DolphinMainWindow::createControlButton()
     Q_ASSERT(!m_controlButton);
 
     m_controlButton = new QToolButton(this);
+    m_controlButton->setAccessibleName(i18nc("@action:intoolbar", "Control"));
     m_controlButton->setIcon(QIcon::fromTheme(QStringLiteral("application-menu")));
     m_controlButton->setToolTip(i18nc("@action", "Show menu"));
     m_controlButton->setAttribute(Qt::WidgetAttribute::WA_CustomWhatsThis);
[prev in list] [next in list] [prev in thread] [next in thread]