[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Name not set on breeze.json
From:       Luiz Fernando Ranghetti <elchevive68 () gmail ! com>
Date:       2018-10-24 14:26:08
Message-ID: CADPAnrzUtK3QH8_d-drDVc6YL2R09a7WaLTECZH1NnoBowiZ6w () mail ! gmail ! com
[Download RAW message or body]

Hi,

Yes, its corrected. Today's scripty injected the translations on .json
files:

https://cgit.kde.org/breeze.git/commit/kdecoration/breeze.json?id=cef36ae4cdae962ecc46bc4163d64cbf9a99ad97


Thanks for fixing it!

Regards,

Luiz

Em ter, 23 de out de 2018 Ã s 19:43, Albert Astals Cid <aacid@kde.org>
escreveu:

> El dimarts, 23 d'octubre de 2018, a les 0:35:43 CEST, Albert Astals Cid va
> escriure:
> > El dimarts, 23 d'octubre de 2018, a les 0:30:20 CEST, Albert Astals Cid
> va escriure:
> > > El dimarts, 23 d'octubre de 2018, a les 0:28:12 CEST, Albert Astals
> Cid va escriure:
> > > > El dilluns, 22 d'octubre de 2018, a les 17:00:19 CEST, Luiz Fernando
> Ranghetti va escriure:
> > > > > Hi guys,
> > > > > 
> > > > > I receive a bug for pt_BR:
> > > > > 
> > > > > https://bugs.kde.org/show_bug.cgi?id=400075
> > > > > 
> > > > > In which the Breeze theme name was translated (we do not translate
> in
> > > > > pt_BR, only pt does translate it).
> > > > > 
> > > > > Looking into json_workspace_breeze.po we have the Name translated
> as
> > > > > "Breeze", but looking into the git only the "Name[lang]" that
> appear on
> > > > > this file are the ones with diferent translations, you can see it
> here:
> > > > > 
> > > > > https://cgit.kde.org/breeze.git/tree/kdecoration/breeze.json
> > > > > 
> > > > > Can this be fixed?
> > > > 
> > > > I was going to say it doesn't need fixing because no translation
> means just use the original one, but that's not correct, no translation
> means use the fallback, which i guess is pt and then you get the pt
> translation.
> > > > 
> > > > I'll have a look but the filling of the .desktop files is done by a
> crazy old c++ program i don't think anyone understands anymore, so i have
> to be careful in not breaking other stuff.
> > > 
> > > And this is about json files so what i said about the C++ program and
> .desktop files makes no sense :D
> > > 
> > > I'll have a look at the proper place now.
> > 
> > https://phabricator.kde.org/D16379
> 
> Commited this, should hopefully be fixed for the next releases, could you
> check?
> 
> Cheers,
> Albert
> 
> > 
> > > 
> > > Cheers,
> > > Albert
> > > 
> > > > 
> > > > Cheers,
> > > > Albert
> > > > 
> > > > > 
> > > > > Regards,
> > > > > 
> > > > > Luiz
> > > > > 
> > > > 
> > > > 
> > > > 
> > > > 
> > > 
> > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> 
> 
> 
> 
> 


[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr">Hi,<div><br></div><div>Yes, its corrected. Today&#39;s \
scripty injected the translations on .json files:</div><div><br></div><div><a \
href="https://cgit.kde.org/breeze.git/commit/kdecoration/breeze.json?id=cef36ae4cdae96 \
2ecc46bc4163d64cbf9a99ad97">https://cgit.kde.org/breeze.git/commit/kdecoration/breeze. \
json?id=cef36ae4cdae962ecc46bc4163d64cbf9a99ad97</a><br></div><div><br></div><div>Thanks \
for fixing it!</div><div><br></div><div>Regards,</div><div><br></div><div>Luiz</div></div></div><br><div \
class="gmail_quote"><div dir="ltr">Em ter, 23 de out de 2018 Ã s 19:43, Albert Astals \
Cid &lt;<a href="mailto:aacid@kde.org">aacid@kde.org</a>&gt; \
escreveu:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">El dimarts, 23 d'octubre de 2018, a \
les 0:35:43 CEST, Albert Astals Cid va escriure:<br> &gt; El dimarts, 23 d'octubre de \
2018, a les 0:30:20 CEST, Albert Astals Cid va escriure:<br> &gt; &gt; El dimarts, 23 \
d'octubre de 2018, a les 0:28:12 CEST, Albert Astals Cid va escriure:<br> &gt; &gt; \
&gt; El dilluns, 22 d'octubre de 2018, a les 17:00:19 CEST, Luiz Fernando Ranghetti \
va escriure:<br> &gt; &gt; &gt; &gt; Hi guys,<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; I receive a bug for pt_BR:<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; <a href="https://bugs.kde.org/show_bug.cgi?id=400075" \
rel="noreferrer" target="_blank">https://bugs.kde.org/show_bug.cgi?id=400075</a><br> \
&gt; &gt; &gt; &gt; <br> &gt; &gt; &gt; &gt; In which the Breeze theme name was \
translated (we do not translate in<br> &gt; &gt; &gt; &gt; pt_BR, only pt does \
translate it).<br> &gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; Looking into json_workspace_breeze.po we have the Name translated \
as<br> &gt; &gt; &gt; &gt; &quot;Breeze&quot;, but looking into the git only the \
&quot;Name[lang]&quot; that appear on<br> &gt; &gt; &gt; &gt; this file are the ones \
with diferent translations, you can see it here:<br> &gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; <a \
href="https://cgit.kde.org/breeze.git/tree/kdecoration/breeze.json" rel="noreferrer" \
target="_blank">https://cgit.kde.org/breeze.git/tree/kdecoration/breeze.json</a><br> \
&gt; &gt; &gt; &gt; <br> &gt; &gt; &gt; &gt; Can this be fixed?<br>
&gt; &gt; &gt; <br>
&gt; &gt; &gt; I was going to say it doesn&#39;t need fixing because no translation \
means just use the original one, but that&#39;s not correct, no translation means use \
the fallback, which i guess is pt and then you get the pt translation.<br> &gt; &gt; \
&gt; <br> &gt; &gt; &gt; I&#39;ll have a look but the filling of the .desktop files \
is done by a crazy old c++ program i don&#39;t think anyone understands anymore, so i \
have to be careful in not breaking other stuff.<br> &gt; &gt; <br>
&gt; &gt; And this is about json files so what i said about the C++ program and \
.desktop files makes no sense :D<br> &gt; &gt; <br>
&gt; &gt; I&#39;ll have a look at the proper place now.<br>
&gt; <br>
&gt; <a href="https://phabricator.kde.org/D16379" rel="noreferrer" \
target="_blank">https://phabricator.kde.org/D16379</a><br> <br>
Commited this, should hopefully be fixed for the next releases, could you check?<br>
<br>
Cheers,<br>
   Albert<br>
<br>
&gt; <br>
&gt; &gt; <br>
&gt; &gt; Cheers,<br>
&gt; &gt;     Albert<br>
&gt; &gt; <br>
&gt; &gt; &gt; <br>
&gt; &gt; &gt; Cheers,<br>
&gt; &gt; &gt;     Albert<br>
&gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; Regards,<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; Luiz<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; <br>
&gt; &gt; &gt; <br>
&gt; &gt; &gt; <br>
&gt; &gt; &gt; <br>
&gt; &gt; <br>
&gt; &gt; <br>
&gt; &gt; <br>
&gt; &gt; <br>
&gt; <br>
&gt; <br>
&gt; <br>
&gt; <br>
<br>
<br>
<br>
<br>
</blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic