[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D14699: Save as saves the file to a new path even if there was no changes
From:       Albert Astals Cid <noreply () phabricator ! kde ! org>
Date:       2018-08-09 18:48:28
Message-ID: 6401f3b80627790e1abb80ad2b73cd63 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

aacid added inline comments.

INLINE COMMENTS

> editortab.cpp:951
> {
> -    bool clean=m_catalog->isClean() && !m_syncView->isModified() && \
> !m_syncViewSecondary->isModified(); +    bool clean=m_catalog->isClean() && \
> !m_syncView->isModified() && !m_syncViewSecondary->isModified() && \
> QString::compare(filePath, m_catalog->url()) == 0; if (clean) return true;

why this weird QString::compare? why not just "filePath == m_catalog->url()" that is \
imho easier to understnad?

REPOSITORY
  R456 Lokalize

REVISION DETAIL
  https://phabricator.kde.org/D14699

To: sdepiets, #localization, aacid, ltoscano, shaforostoff, mlaurent
Cc: michaldybczak, sdepiets, skadinna, huftis


[Attachment #3 (text/html)]

<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14699">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14699#inline-77804">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">editortab.cpp:951</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span \
style="color: #aa4000">bool</span> <span class="n">clean</span><span style="color: \
#aa2211">=</span><span class="n">m_catalog</span><span style="color: \
#aa2211">-&gt;</span><span class="n">isClean</span><span class="p">()</span> <span \
style="color: #aa2211">&amp;&amp;</span> <span style="color: #aa2211">!</span><span \
class="n">m_syncView</span><span style="color: #aa2211">-&gt;</span><span \
class="n">isModified</span><span class="p">()</span> <span style="color: \
#aa2211">&amp;&amp;</span> <span style="color: #aa2211">!</span><span \
class="n">m_syncViewSecondary</span><span style="color: #aa2211">-&gt;</span><span \
class="n">isModified</span><span class="p">();</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: \
#aa4000">bool</span> <span class="n">clean</span><span style="color: \
#aa2211">=</span><span class="n">m_catalog</span><span style="color: \
#aa2211">-&gt;</span><span class="n">isClean</span><span class="p">()</span> <span \
style="color: #aa2211">&amp;&amp;</span> <span style="color: #aa2211">!</span><span \
class="n">m_syncView</span><span style="color: #aa2211">-&gt;</span><span \
class="n">isModified</span><span class="p">()</span> <span style="color: \
#aa2211">&amp;&amp;</span> <span style="color: #aa2211">!</span><span \
class="n">m_syncViewSecondary</span><span style="color: #aa2211">-&gt;</span><span \
class="n">isModified</span><span class="p">()<span class="bright"></span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">&amp;&amp;</span></span><span class="bright"> </span><span \
class="n"><span class="bright">QString</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span class="bright">compare</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">filePath</span></span><span class="bright"></span><span \
class="p"><span class="bright">,</span></span><span class="bright"> </span><span \
class="n"><span class="bright">m_catalog</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">-&gt;</span></span><span class="bright"></span><span class="n"><span \
class="bright">url</span></span><span class="bright"></span><span class="p"><span \
class="bright">())</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">==</span></span><span class="bright"> </span><span \
style="color: #601200"><span class="bright">0</span></span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: \
#aa4000">if</span> <span class="p">(</span><span class="n">clean</span><span \
class="p">)</span> <span style="color: #aa4000">return</span> <span style="color: \
#304a96">true</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why \
this weird QString::compare? why not just &quot;filePath == m_catalog-&gt;url()&quot; \
that is imho easier to understnad?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14699">https://phabricator.kde.org/D14699</a></div></div><br \
/><div><strong>To: </strong>sdepiets, Localization, aacid, ltoscano, shaforostoff, \
mlaurent<br /><strong>Cc: </strong>michaldybczak, sdepiets, skadinna, huftis<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]