[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D14069: Add a feature to remove deleted files entries from TM
From:       Albert Astals Cid <noreply () phabricator ! kde ! org>
Date:       2018-07-31 21:47:51
Message-ID: 9a1406c2b96537929a9be0901ac850bd () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

aacid added a comment.


  Do i understand it correctly that we only remove the file on
  
  openFile and on right click?
  
  You mention rescan but i don't see where it happens for rescan.
  
  Also to me it seems that you copied and pasted a sizable chunk of code in three \
places, can we get that in one place only?

INLINE COMMENTS

> lokalize.kcfg:120
> +    </entry>
> +    <entry name="IgnoreObsoleteForTM"  type="Bool">
> +        <default>false</default>

This is not used?

> tmtab.cpp:553
> +    {
> +      RemoveMissingFilesJob* job=new \
> RemoveMissingFilesJob(Project::instance()->projectID()); +      \
> TM::threadPool()->start(job, REMOVEMISSINGFILES);

Nitpicking seems the spacing is a bit off here.

REPOSITORY
  R456 Lokalize

REVISION DETAIL
  https://phabricator.kde.org/D14069

To: sdepiets, aacid, ltoscano, shaforostoff, #localization, mlaurent
Cc: mlaurent


[Attachment #3 (text/html)]

<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14069">View Revision</a></tr></table><br \
/><div><div><p>Do i understand it correctly that we only remove the file on</p>

<p>openFile and on right click?</p>

<p>You mention rescan but i don&#039;t see where it happens for rescan.</p>

<p>Also to me it seems that you copied and pasted a sizable chunk of code in three \
places, can we get that in one place only?</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14069#inline-76709">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">lokalize.kcfg:120</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    \
&lt;/entry&gt; </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, \
234, 151, .6);">    &lt;entry name=&quot;IgnoreObsoleteForTM&quot;  \
type=&quot;Bool&quot;&gt; </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">        &lt;default&gt;false&lt;/default&gt; \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">This is not used?</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14069#inline-76710">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">tmtab.cpp:553</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">      <span class="n">RemoveMissingFilesJob</span><span \
style="color: #aa2211">*</span> <span class="n">job</span><span style="color: \
#aa2211">=</span><span style="color: #aa4000">new</span> <span \
class="n">RemoveMissingFilesJob</span><span class="p">(</span><span \
class="n">Project</span><span style="color: #aa2211">::</span><span \
class="n">instance</span><span class="p">()</span><span style="color: \
#aa2211">-&gt;</span><span class="n">projectID</span><span class="p">());</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">      <span class="n">TM</span><span style="color: #aa2211">::</span><span \
class="n">threadPool</span><span class="p">()</span><span style="color: \
#aa2211">-&gt;</span><span class="n">start</span><span class="p">(</span><span \
class="n">job</span><span class="p">,</span> <span \
class="n">REMOVEMISSINGFILES</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Nitpicking seems the spacing is a bit off \
here.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R456 Lokalize</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14069">https://phabricator.kde.org/D14069</a></div></div><br \
/><div><strong>To: </strong>sdepiets, aacid, ltoscano, shaforostoff, Localization, \
mlaurent<br /><strong>Cc: </strong>mlaurent<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]