[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    D9696: implement a metadata view for tracks
From:       Matthieu Gallien <noreply () phabricator ! kde ! org>
Date:       2018-01-08 21:35:36
Message-ID: 20180108213536.1.E2BC0062DBD8BB7F () phabricator ! kde ! org
[Download RAW message or body]

mgallien added subscribers: kde-i18n-doc, ltoscano.
mgallien added a comment.


  I have few small comments:
  
  - the colon is french has a space before and after. You should probably have a look \
at a way to have the whole string given to i18n functions. You can use placeholder \
like %1. @ltoscano and others in @kde-i18n-doc can probably give useful advice on \
                this subject;
  - It would feel more natural to me to have the item being shown to also be selected \
                in the ListView (i.e. made the current item) ;
  - what do you think of also adding it to the playlist ? Maybe this can be done in a \
latter diff.

REPOSITORY
  R255 Elisa

REVISION DETAIL
  https://phabricator.kde.org/D9696

To: astippich, #elisa, mgallien
Cc: ltoscano, kde-i18n-doc, ognarb, alexeymin, skadinna, kmf, progwolff, andreask, \
aaronhoneycutt, mgallien, mbohlender


[Attachment #3 (unknown)]

<table><tr><td style="">mgallien added subscribers: kde-i18n-doc, ltoscano.<br \
/>mgallien added a comment. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9696" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I have few small comments:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">the colon is french has a space before and after. You \
should probably have a look at a way to have the whole string given to i18n \
functions. You can use placeholder like %1. <a \
href="https://phabricator.kde.org/p/ltoscano/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@ltoscano</a> and others in <a \
href="https://phabricator.kde.org/p/kde-i18n-doc/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@kde-i18n-doc</a> can probably give \
useful advice on this subject;</li> <li class="remarkup-list-item">It would feel more \
natural to me to have the item being shown to also be selected in the ListView (i.e. \
made the current item) ;</li> <li class="remarkup-list-item">what do you think of \
also adding it to the playlist ? Maybe this can be done in a latter diff.</li> \
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R255 \
Elisa</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9696" \
rel="noreferrer">https://phabricator.kde.org/D9696</a></div></div><br \
/><div><strong>To: </strong>astippich, Elisa, mgallien<br /><strong>Cc: \
</strong>ltoscano, kde-i18n-doc, ognarb, alexeymin, skadinna, kmf, progwolff, \
andreask, aaronhoneycutt, mgallien, mbohlender<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]