[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    [Differential] [Commented On] D4795: Correctly load the Qt-native translations
From:       Luigi Toscano <noreply () phabricator ! kde ! org>
Date:       2017-02-27 18:56:48
Message-ID: 20170227185647.6254.43174.2B068EE0 () phabricator ! kde ! org
[Download RAW message or body]

ltoscano added a comment.


  In https://phabricator.kde.org/D4795#90471, @weidendo wrote:
  
  > Regarding qcachegrind: I do not really see a need for translation here, as there \
is nothing installed. However, it should not be  >  any overhead to add translations, \
as it really only should reuse strings also found in KCachegrind (I try to keep the \
GUI in sync  >  as good as possible).
  
  
  qcachegrind and kcachegrind uses two different translation systems, and right now \
the strings for kcachegrind are extracted in kcachegrind.po, which  would not be \
directly usable for qcachegrind (the native Qt system uses translation context in \
a... peculiar way).  
  But that's can be dealt separately; if you accept the review (with the specific \
option :) it would be an improvement already.  
  (the things I'd like to more is whether my guess about Q_COREAPP_STARTUP_FUNCTION \
is correct, but the solution so far is fine and the problem is limited to only 2 \
applications on all kde.org afaik, so it's fine).

REPOSITORY
  R49 KCacheGrind

REVISION DETAIL
  https://phabricator.kde.org/D4795

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, #localization
Cc: weidendo, aacid, #localization


[Attachment #3 (text/html)]

<table><tr><td style="">ltoscano added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4795" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D4795#90471" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D4795#90471</a>, <a \
href="https://phabricator.kde.org/p/weidendo/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@weidendo</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Regarding qcachegrind: I do not really see a \
need for translation here, as there is nothing installed. However, it should not \
be<br />  any overhead to add translations, as it really only should reuse strings \
also found in KCachegrind (I try to keep the GUI in sync<br />  as good as \
possible).</p></div> </blockquote>

<p>qcachegrind and kcachegrind uses two different translation systems, and right now \
the strings for kcachegrind are extracted in kcachegrind.po, which  would not be \
directly usable for qcachegrind (the native Qt system uses translation context in \
a... peculiar way).</p>

<p>But that&#039;s can be dealt separately; if you accept the review (with the \
specific option :) it would be an improvement already.</p>

<p>(the things I&#039;d like to more is whether my guess about \
Q_COREAPP_STARTUP_FUNCTION is correct, but the solution so far is fine and the \
problem is limited to only 2 applications on all kde.org afaik, so it&#039;s \
fine).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R49 \
KCacheGrind</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4795" \
rel="noreferrer">https://phabricator.kde.org/D4795</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>ltoscano, Localization<br /><strong>Cc: \
</strong>weidendo, aacid, Localization<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]