[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    [Differential] [Commented On] D4795: Correctly load the Qt-native translations
From:       Josef Weidendorfer <noreply () phabricator ! kde ! org>
Date:       2017-02-27 13:41:35
Message-ID: 20170227134134.20518.10113.1B631DC0 () phabricator ! kde ! org
[Download RAW message or body]

weidendo added a comment.


  Thanks for patch!
  
  As I do not really know how this is expected to work, I only can test this on my \
system (in the next days). But the patch looks  simple enough, and if you say it \
works on your system, I am fine with the patch.  
  Regarding qcachegrind: I do not really see a need for translation here, as there is \
nothing installed. However, it should not be  any overhead to add translations, as it \
really only should reuse strings also found in KCachegrind (I try to keep the GUI in \
sync  as good as possible).

REPOSITORY
  R49 KCacheGrind

REVISION DETAIL
  https://phabricator.kde.org/D4795

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, #localization
Cc: weidendo, aacid, #localization


[Attachment #3 (text/html)]

<table><tr><td style="">weidendo added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4795" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Thanks for patch!</p>

<p>As I do not really know how this is expected to work, I only can test this on my \
system (in the next days). But the patch looks<br /> simple enough, and if you say it \
works on your system, I am fine with the patch.</p>

<p>Regarding qcachegrind: I do not really see a need for translation here, as there \
is nothing installed. However, it should not be<br /> any overhead to add \
translations, as it really only should reuse strings also found in KCachegrind (I try \
to keep the GUI in sync<br /> as good as possible).</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R49 KCacheGrind</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4795" \
rel="noreferrer">https://phabricator.kde.org/D4795</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>ltoscano, Localization<br /><strong>Cc: \
</strong>weidendo, aacid, Localization<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]