[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    [Differential] [Request, 4 lines] D4793: Correctly load the Qt-native translations
From:       Luigi Toscano <noreply () phabricator ! kde ! org>
Date:       2017-02-25 21:08:41
Message-ID: differential-rev-PHID-DREV-kwdt4tnfkxtbieb57pgq-req () phabricator ! kde ! org
[Download RAW message or body]

ltoscano created this revision.

REVISION SUMMARY
  ecm_create_qm_loader() uses Q_COREAPP_STARTUP_FUNCTION to inject the
  loader of the additiona translator. The macro does not seem to work
  when the loader is linked in a separate static library (the code
  which uses Qt translations is all inside stepcore).
  So call the ECM macro (and then link the special loader) where
  the Q(Core)Application is defined.
  Many previously untranslated strings are not translated.
  Some additional work is needed but it probably depends on the
  special structure of stepcore.

TEST PLAN
  The code compiles, and the name of the objects (left pane) and the
  properties (part of the right pane) are translated

REPOSITORY
  R341 Step

BRANCH
  Applications/16.12

REVISION DETAIL
  https://phabricator.kde.org/D4793

AFFECTED FILES
  step/CMakeLists.txt
  stepcore/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, #localization
Cc: #localization

[Attachment #3 (text/html)]

<table><tr><td style="">ltoscano created this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4793" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>ecm_create_qm_loader() uses Q_COREAPP_STARTUP_FUNCTION to \
inject the<br /> loader of the additiona translator. The macro does not seem to \
work<br /> when the loader is linked in a separate static library (the code<br />
which uses Qt translations is all inside stepcore).<br />
So call the ECM macro (and then link the special loader) where<br />
the Q(Core)Application is defined.<br />
Many previously untranslated strings are not translated.<br />
Some additional work is needed but it probably depends on the<br />
special structure of stepcore.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>The code compiles, and the name of the objects (left pane) and \
the<br /> properties (part of the right pane) are translated</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R341 Step</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>Applications/16.12</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4793" \
rel="noreferrer">https://phabricator.kde.org/D4793</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>step/CMakeLists.txt<br /> \
stepcore/CMakeLists.txt</div></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>ltoscano, Localization<br /><strong>Cc: \
</strong>Localization<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]