[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: [Differential] [Accepted] D4356: Fix UI string: remove placeholders for arguments
From: Burkhard_Lück <noreply () phabricator ! kde ! org>
Date: 2017-01-31 8:24:36
Message-ID: 20170131082436.8946.55233.A6A04EA0 () phabricator ! kde ! org
[Download RAW message or body]
lueck accepted this revision.
lueck added a reviewer: lueck.
lueck added a comment.
This revision is now accepted and ready to land.
with the patch the I18n_ARGUMENT_MISSING error
INLINE COMMENTS
> diffmergesettings.ui:187-188
> <br>
> If using first or second form, svn itself will generate the diff. %f will replaced \
> with a temporary filename. If %f is not given, the diff-display should able reading \
> data from stdin. <br>
Probably the string could be improved:
If using the first or second form, svn itself will generate the diff. %f will be \
replaced with a temporary filename. If %f is not given, the diff-display should able \
to read data from stdin.
> diffmergesettings.ui:190
> <br>
> -When %1 and %2 is given, kdesvn let this display make the diff. For that it it \
> makes a temporary export or get (if needed) and fill out the parameters with the \
> right value. %1 will filled with the content of start-revision, %2 with the \
> endrevision. On large recoursive diffs this may get real slow! +When %s1 and %s2 is \
> given, kdesvn let this display make the diff. For that it it makes a temporary \
> export or get (if needed) and fill out the parameters with the right value. %s1 \
> will filled with the content of start-revision, %s2 with the endrevision. On large \
> recoursive diffs this may get real slow! </p></string>
Probably the string could be improved:
When %1 and %2 are given, kdesvn lets this display make the diff. For that it makes a \
temporary export or get (if needed) and fill out the parameters with the right value. \
%1 will be filled with the content of start-revision, %2 with the endrevision. On \
large recursive diffs this may get real slow.
REPOSITORY
R220 Subversion Client (KDE SVN)
BRANCH
fix-i18n-error
REVISION DETAIL
https://phabricator.kde.org/D4356
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ltoscano, chehrlic, lueck
Cc: lueck, #localization, huftis
[Attachment #3 (text/html)]
<table><tr><td style="">lueck accepted this revision.<br />lueck added a reviewer: \
lueck.<br />lueck added a comment.<br />This revision is now accepted and ready to \
land. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4356" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>with the patch the I18n_ARGUMENT_MISSING \
error</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4356#inline-17434" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">diffmergesettings.ui:187-188</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">&lt;br&gt; </div><div style="padding: 0 8px; margin: 0 4px; \
">If using first or second form, svn itself will generate the diff. %f will replaced \
with a temporary filename. If %f is not given, </div><div style="padding: 0 8px; \
margin: 0 4px; ">the diff-display should able reading data from stdin. </div><div \
style="padding: 0 8px; margin: 0 4px; ">&lt;br&gt; </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Probably the string could be improved:<br /> If using the first or second form, \
svn itself will generate the diff. %f will be replaced with a temporary filename. If \
%f is not given,<br /> the diff-display should able to read data from \
stdin.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4356#inline-17435" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">diffmergesettings.ui:190</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">&lt;br&gt; </div><div style="padding: 0 8px; margin: 0 4px; \
background: #ffd0d0;">When %<span class="bright">1 and %2 is given, kdesvn let this \
display make the diff. For that it it makes a temporary export or get (if needed) and \
fill out the parameters with the right value. %1 will filled with the content of \
start-revision, %</span>2 with the endrevision. On large recoursive diffs this may \
get real slow! </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;">When %<span class="bright">s1 and %s2 is given, kdesvn let this display \
make the diff. For that it it makes a temporary export or get (if needed) and fill \
out the parameters with the right value. %s1 will filled with the content of \
start-revision, %s</span>2 with the endrevision. On large recoursive diffs this may \
get real slow! </div><div style="padding: 0 8px; margin: 0 4px; \
">&lt;/p&gt;</string> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Probably the string could be improved:<br /> When %1 and %2 are given, kdesvn \
lets this display make the diff. For that it makes a temporary export or get (if \
needed)<br /> and fill out the parameters with the right value. %1 will be filled \
with the content of start-revision, %2 with the endrevision. On large recursive diffs \
this may get real slow.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R220 Subversion Client (KDE \
SVN)</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>fix-i18n-error</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4356" \
rel="noreferrer">https://phabricator.kde.org/D4356</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>ltoscano, chehrlic, lueck<br /><strong>Cc: \
</strong>lueck, Localization, huftis<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic