--a7cfa555e9ce4ab2b5ce0fcd14508567
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

lueck accepted this revision.
lueck added a reviewer: lueck.
lueck added a comment.
This revision is now accepted and ready to land.


  with the patch the I18n_ARGUMENT_MISSING error

INLINE COMMENTS

> diffmergesettings.ui:187-188
>  <br>
>  If using first or second form, svn itself will generate the diff. %f will replaced with a temporary filename. If %f is not given,
>  the diff-display should able reading data from stdin.
>  <br>

Probably the string could be improved:
If using the first or second form, svn itself will generate the diff. %f will be replaced with a temporary filename. If %f is not given,
the diff-display should able to read data from stdin.

> diffmergesettings.ui:190
>  <br>
> -When %1 and %2 is given, kdesvn let this display make the diff. For that it it makes a temporary export or get (if needed) and fill out the parameters with the right value. %1 will filled with the content of start-revision, %2 with the endrevision. On large recoursive diffs this may get real slow!
> +When %s1 and %s2 is given, kdesvn let this display make the diff. For that it it makes a temporary export or get (if needed) and fill out the parameters with the right value. %s1 will filled with the content of start-revision, %s2 with the endrevision. On large recoursive diffs this may get real slow!
>  &lt;/p&gt;</string>

Probably the string could be improved:
When %1 and %2 are given, kdesvn lets this display make the diff. For that it makes a temporary export or get (if needed)
and fill out the parameters with the right value. %1 will be filled with the content of start-revision, %2 with the endrevision. On large recursive diffs this may get real slow.

REPOSITORY
  R220 Subversion Client (KDE SVN)

BRANCH
  fix-i18n-error

REVISION DETAIL
  https://phabricator.kde.org/D4356

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, chehrlic, lueck
Cc: lueck, #localization, huftis

--a7cfa555e9ce4ab2b5ce0fcd14508567
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td style=3D"">lueck accepted this revision.<br />lueck added a =
reviewer: lueck.<br />lueck added a comment.<br />This revision is now acce=
pted and ready to land.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D4356" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><div><p>with the patch the I18n_ARGUMENT_MISSING er=
ror</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div sty=
le=3D"margin: 6px 0 12px 0;"><div style=3D"border: 1px solid #C7CCD9; borde=
r-radius: 3px;"><div style=3D"padding: 0; background: #F7F7F7; border-color=
: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div s=
tyle=3D"color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hi=
dden;"><a style=3D"float: right; text-decoration: none;" href=3D"https://ph=
abricator.kde.org/D4356#inline-17434" rel=3D"noreferrer">View Inline</a><sp=
an style=3D"color: #4b4d51; font-weight: bold;">diffmergesettings.ui:187-18=
8</span></div>
<div style=3D"font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quo=
t;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px=
 0; margin: 0;"><div style=3D"padding: 0 8px; margin: 0 4px; ">&amp;lt;br&a=
mp;gt;
</div><div style=3D"padding: 0 8px; margin: 0 4px; ">If using first or seco=
nd form, svn itself will generate the diff. %f will replaced with a tempora=
ry filename. If %f is not given,
</div><div style=3D"padding: 0 8px; margin: 0 4px; ">the diff-display shoul=
d able reading data from stdin.
</div><div style=3D"padding: 0 8px; margin: 0 4px; ">&amp;lt;br&amp;gt;
</div></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">Probably the string could be improved:<br />
If using the first or second form, svn itself will generate the diff. %f wi=
ll be replaced with a temporary filename. If %f is not given,<br />
the diff-display should able to read data from stdin.</p></div></div><br />=
<div style=3D"border: 1px solid #C7CCD9; border-radius: 3px;"><div style=3D=
"padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: soli=
d; border-width: 0 0 1px 0; margin: 0;"><div style=3D"color: #74777d; backg=
round: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style=3D"float: rig=
ht; text-decoration: none;" href=3D"https://phabricator.kde.org/D4356#inlin=
e-17435" rel=3D"noreferrer">View Inline</a><span style=3D"color: #4b4d51; f=
ont-weight: bold;">diffmergesettings.ui:190</span></div>
<div style=3D"font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quo=
t;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px=
 0; margin: 0;"><div style=3D"padding: 0 8px; margin: 0 4px; ">&amp;lt;br&a=
mp;gt;
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: #ffd0d0;">Wh=
en %<span class=3D"bright">1 and %2 is given, kdesvn let this display make =
the diff. For that it it makes a temporary export or get (if needed) and fi=
ll out the parameters with the right value. %1 will filled with the content=
 of start-revision, %</span>2 with the endrevision. On large recoursive dif=
fs this may get real slow!
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: #d0ffd0;">Wh=
en %<span class=3D"bright">s1 and %s2 is given, kdesvn let this display mak=
e the diff. For that it it makes a temporary export or get (if needed) and =
fill out the parameters with the right value. %s1 will filled with the cont=
ent of start-revision, %s</span>2 with the endrevision. On large recoursive=
 diffs this may get real slow!
</div><div style=3D"padding: 0 8px; margin: 0 4px; ">&amp;lt;/p&amp;gt;&lt;=
/string&gt;
</div></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">Probably the string could be improved:<br />
When %1 and %2 are given, kdesvn lets this display make the diff. For that =
it makes a temporary export or get (if needed)<br />
and fill out the parameters with the right value. %1 will be filled with th=
e content of start-revision, %2 with the endrevision. On large recursive di=
ffs this may get real slow.</p></div></div></div></div></div><br /><div><st=
rong>REPOSITORY</strong><div><div>R220 Subversion Client (KDE SVN)</div></d=
iv></div><br /><div><strong>BRANCH</strong><div><div>fix-i18n-error</div></=
div></div><br /><div><strong>REVISION DETAIL</strong><div><a href=3D"https:=
//phabricator.kde.org/D4356" rel=3D"noreferrer">https://phabricator.kde.org=
/D4356</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a =
href=3D"https://phabricator.kde.org/settings/panel/emailpreferences/" rel=
=3D"noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences=
/</a></div></div><br /><div><strong>To: </strong>ltoscano, chehrlic, lueck<=
br /><strong>Cc: </strong>lueck, Localization, huftis<br /></div>
--a7cfa555e9ce4ab2b5ce0fcd14508567--