[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: [Differential] [Commented On] D4023: kformat: Make it possible to properly translate relative days o
From: Albert Astals Cid <noreply () phabricator ! kde ! org>
Date: 2017-01-14 23:11:04
Message-ID: 20170114231104.11230.98152.3550A384 () phabricator ! kde ! org
[Download RAW message or body]
aacid added a comment.
In https://phabricator.kde.org/D4023#76899, @mpyne wrote:
> In https://phabricator.kde.org/D4023#76891, @aacid wrote:
>
> > I find the comments misleading (maybe because i'm not english native) but
> >
> > if (daysTo < -1) {
> > switch (date.dayOfWeek()) {
> > case 1:
> > return tr("Last Monday", "day in the previous week");
> > case 2:
> >
> >
> > Why does it have to be the previous week? If today is Wednesday and the date \
we're referring to is Monday, daysTo will be -2 and it will still be the current week \
and not the previous, no? > >
> > else if (daysTo > 1) {
> >
> > switch (date.dayOfWeek()) {
> > case 4:
> > return tr("Next Thursday", "day in the week after this");
> >
> >
> > If today is Monday and the date we're referring to is Thursday, daysTo will be \
3 and it's not "the week after this" it's "this week". > >
> > Or am i understanding something wrong?
>
>
> You're right. What's a better phrasing? Or, is the context even necessary for \
translators here?
I'd say let's go with context, or maybe even better english (or more codepaths?)
Can you as a native speaker confirm this theory i've heard?
If we are on "Monday 16", "Next Wednesday" means "Wednesday 25" if you want \
"Wednesday 18" you should say "This Wednesday"
> Maybe something like "the most recent such day before today" and "the next such \
day after today"?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4023
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mpyne, #frameworks, kde-i18n-doc, aspotashev, aacid
Cc: aacid
[Attachment #3 (text/html)]
<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4023" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D4023#76899" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D4023#76899</a>, <a \
href="https://phabricator.kde.org/p/mpyne/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@mpyne</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D4023#76891" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D4023#76891</a>, <a \
href="https://phabricator.kde.org/p/aacid/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@aacid</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I find the comments misleading (maybe \
because i'm not english native) but</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (daysTo < -1) { switch \
(date.dayOfWeek()) { case 1:
return tr("Last Monday", "day in the previous \
week"); case 2:</pre></div>
<p>Why does it have to be the previous week? If today is Wednesday and the date \
we're referring to is Monday, daysTo will be -2 and it will still be the current \
week and not the previous, no?</p>
<p>else if (daysTo > 1) {</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">switch (date.dayOfWeek()) { \
case 4: return tr("Next Thursday", "day in the week after \
this");</pre></div>
<p>If today is Monday and the date we're referring to is Thursday, daysTo will \
be 3 and it's not "the week after this" it's "this \
week".</p>
<p>Or am i understanding something wrong?</p></div>
</blockquote>
<p>You're right. What's a better phrasing? Or, is the context even \
necessary for translators here?</p></div> </blockquote>
<p>I'd say let's go with context, or maybe even better english (or more \
codepaths?)</p>
<p>Can you as a native speaker confirm this theory i've heard?</p>
<p>If we are on "Monday 16", "Next Wednesday" means \
"Wednesday 25" if you want "Wednesday 18" you should say \
"This Wednesday"</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Maybe \
something like "the most recent such day before today" and "the next \
such day after today"?</p></blockquote>
</div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 \
KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4023" \
rel="noreferrer">https://phabricator.kde.org/D4023</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mpyne, Frameworks, kde-i18n-doc, aspotashev, aacid<br \
/><strong>Cc: </strong>aacid<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic