'Re: Review Request 126838: Fix a plural issue with unit count string'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Review Request 126838: Fix a plural issue with unit count string
From:       Safa Alfulaij <safa1996alfulaij () gmail ! com>
Date:       2016-02-09 0:25:17
Message-ID: 20160209002517.23891.83494 () mimi ! kde ! org
[Download RAW message or body]

--===============8600184861416244233==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126838/
-----------------------------------------------------------

(Updated Feb. 9, 2016, 1:25 a.m.)


Status
------

This change has been marked as submitted.


Review request for Localization and Translation (l10n) and Ragnar Thomsen.


Changes
-------

Submitted with commit e475c502fa77090f059734a1f2e5562134253bf6 by Albert Astals Cid \
on behalf of Safa Alfulaij to branch master.


Repository: systemd-kcm


Description
-------

There is a plural string marked for translation by i18n instead of i18np.
It is "Total: %1 units, %2 active, %3 displayed", each part should be a separate \
plural string to be correctly translated. This patch fixes this.


Diffs
-----

  src/kcmsystemd.cpp d9d9be1 

Diff: https://git.reviewboard.kde.org/r/126838/diff/


Testing
-------


Thanks,

Safa Alfulaij


--===============8600184861416244233==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126838/">https://git.reviewboard.kde.org/r/126838/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Localization and Translation (l10n) and Ragnar Thomsen.</div>
<div>By Safa Alfulaij.</div>


<p style="color: grey;"><i>Updated Feb. 9, 2016, 1:25 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit e475c502fa77090f059734a1f2e5562134253bf6 by Albert \
Astals Cid on behalf of Safa Alfulaij to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
systemd-kcm
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There is a plural string marked for translation by \
i18n instead of i18np. It is "Total: %1 units, %2 active, %3 displayed", each part \
should be a separate plural string to be correctly translated. This patch fixes \
this.</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kcmsystemd.cpp <span style="color: grey">(d9d9be1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126838/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============8600184861416244233==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic