[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 126879: [digital-clock] Use iso-codes for country names
From: Martin Klapetek <martin.klapetek () gmail ! com>
Date: 2016-01-25 16:08:45
Message-ID: 20160125160845.17778.41701 () mimi ! kde ! org
[Download RAW message or body]
--===============4391239868162448360==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/#review91586
-----------------------------------------------------------
Ship it!
Looks good, thanks!
- Martin Klapetek
On Jan. 24, 2016, 10:58 p.m., Pino Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126879/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 10:58 p.m.)
>
>
> Review request for Localization and Translation (l10n), Plasma and John Layt.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Instead of an hardcoded list of translations of country names, look them up in the \
> iso_3166 domain, provided by iso-codes. The names of countries are changes to \
> their ISO 3166 versions in iso-codes.
> Look for iso-codes in cmake, but just as indication of it as runtime dependency.
>
>
> Diffs
> -----
>
> applets/digital-clock/plugin/CMakeLists.txt \
> c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 \
> applets/digital-clock/plugin/timezonesi18n.cpp \
> 6bb465e68bfba4695c79898d630dec5a7075a058 cmake/FindIsoCodes.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/126879/diff/
>
>
> Testing
> -------
>
> With Plasma 5.3 (but this code is the same as in master), the configuration of \
> timezoned in the digital clock is translated according to iso-codes.
>
> Thanks,
>
> Pino Toscano
>
>
--===============4391239868162448360==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126879/">https://git.reviewboard.kde.org/r/126879/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good, thanks!</p></pre> <br />
<p>- Martin Klapetek</p>
<br />
<p>On January 24th, 2016, 10:58 p.m. CET, Pino Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Localization and Translation (l10n), Plasma and John \
Layt.</div> <div>By Pino Toscano.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2016, 10:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Instead of an hardcoded list of translations of \
country names, look them up in the iso_3166 domain, provided by iso-codes. The names \
of countries are changes to their ISO 3166 versions in iso-codes.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Look for iso-codes in cmake, but just as indication of it as runtime \
dependency.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With Plasma 5.3 (but this code is the same as in \
master), the configuration of timezoned in the digital clock is translated according \
to iso-codes.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/plugin/CMakeLists.txt <span style="color: \
grey">(c22c82a75fe6efecc4a249ebd7e045a6f0385ac5)</span></li>
<li>applets/digital-clock/plugin/timezonesi18n.cpp <span style="color: \
grey">(6bb465e68bfba4695c79898d630dec5a7075a058)</span></li>
<li>cmake/FindIsoCodes.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126879/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4391239868162448360==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic