--===============4391239868162448360== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/#review91586 ----------------------------------------------------------- Ship it! Looks good, thanks! - Martin Klapetek On Jan. 24, 2016, 10:58 p.m., Pino Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126879/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2016, 10:58 p.m.) > > > Review request for Localization and Translation (l10n), Plasma and John Layt. > > > Repository: plasma-workspace > > > Description > ------- > > Instead of an hardcoded list of translations of country names, look them up in the iso_3166 domain, provided by iso-codes. The names of countries are changes to their ISO 3166 versions in iso-codes. > > Look for iso-codes in cmake, but just as indication of it as runtime dependency. > > > Diffs > ----- > > applets/digital-clock/plugin/CMakeLists.txt c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 > applets/digital-clock/plugin/timezonesi18n.cpp 6bb465e68bfba4695c79898d630dec5a7075a058 > cmake/FindIsoCodes.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126879/diff/ > > > Testing > ------- > > With Plasma 5.3 (but this code is the same as in master), the configuration of timezoned in the digital clock is translated according to iso-codes. > > > Thanks, > > Pino Toscano > > --===============4391239868162448360== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/

Ship it! 

Looks good, thanks!

- Martin Klapetek


On January 24th, 2016, 10:58 p.m. CET, Pino Toscano wrote:

Review request for Localization and Translation (l10n), Plasma and John Layt.
By Pino Toscano.

Updated Jan. 24, 2016, 10:58 p.m.

Repository: plasma-workspace

Description 

Instead of an hardcoded list of translations of country names, look them up in the iso_3166 domain, provided by iso-codes.  The names of countries are changes to their ISO 3166 versions in iso-codes.


Look for iso-codes in cmake, but just as indication of it as runtime dependency.

Testing 

With Plasma 5.3 (but this code is the same as in master), the configuration of timezoned in the digital clock is translated according to iso-codes.

Diffs

  • applets/digital-clock/plugin/CMakeLists.txt (c22c82a75fe6efecc4a249ebd7e045a6f0385ac5)
  • applets/digital-clock/plugin/timezonesi18n.cpp (6bb465e68bfba4695c79898d630dec5a7075a058)
  • cmake/FindIsoCodes.cmake (PRE-CREATION)

View Diff
--===============4391239868162448360==--