[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Review Request 126496: Fix message extraction: restrict to real i18n strings
From:       "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date:       2015-12-28 16:00:36
Message-ID: 20151228160036.18086.42033 () mimi ! kde ! org
[Download RAW message or body]

--===============0229217912637360676==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126496/
-----------------------------------------------------------

(Updated Dec. 28, 2015, 4 p.m.)


Status
------

This change has been marked as submitted.


Review request for Localization and Translation (l10n) and Martin Klapetek.


Changes
-------

Submitted with commit 9ac2152b2e5f56cc507ddf48f5ee158f83fa500b by Luigi Toscano to \
branch Applications/15.12.


Repository: kaccounts-providers


Description
-------

Previously all strings were extracted (see review 120618), but it is not possible to \
blindly extract all strings now because the repository contains also code. The \
messages extracted by intltool-extract are marked by N_ function, which is now added \
to the list of keywords recognized by xgettext. Other keywords are still recognized.


Diffs
-----

  Messages.sh 67d0db4 

Diff: https://git.reviewboard.kde.org/r/126496/diff/


Testing
-------

Tested extraction with extract-messages.sh; messages from .h/.cpp files not marked by \
*i18n are not extracted anymore, while messages handled from intltools-extract are \
still extracted.


Thanks,

Luigi Toscano


--===============0229217912637360676==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126496/">https://git.reviewboard.kde.org/r/126496/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Localization and Translation (l10n) and Martin \
Klapetek.</div> <div>By Luigi Toscano.</div>


<p style="color: grey;"><i>Updated Dec. 28, 2015, 4 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 9ac2152b2e5f56cc507ddf48f5ee158f83fa500b by Luigi \
Toscano to branch Applications/15.12.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kaccounts-providers
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Previously all strings were extracted (see review 120618), but it is not \
possible to blindly extract all strings now because the repository contains also \
code. The messages extracted by intltool-extract are marked by N_ function, which is \
now added to the list of keywords recognized by xgettext. Other keywords are still \
recognized.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested extraction with extract-messages.sh; messages from .h/.cpp files \
not marked by *i18n are not extracted anymore, while messages handled from \
intltools-extract are still extracted.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>Messages.sh <span style="color: grey">(67d0db4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126496/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============0229217912637360676==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic