'Re: Review Request 126496: Fix message extraction: restrict to real i18n strings'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Review Request 126496: Fix message extraction: restrict to real i18n strings
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2015-12-28 15:30:28
Message-ID: 20151228153028.18086.83718 () mimi ! kde ! org
[Download RAW message or body]

--===============1251162115801639046==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126496/#review90223
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On des. 24, 2015, 12:27 a.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126496/
> -----------------------------------------------------------
> 
> (Updated des. 24, 2015, 12:27 a.m.)
> 
> 
> Review request for Localization and Translation (l10n) and Martin Klapetek.
> 
> 
> Repository: kaccounts-providers
> 
> 
> Description
> -------
> 
> Previously all strings were extracted (see review 120618), but it is not possible \
> to blindly extract all strings now because the repository contains also code. The \
> messages extracted by intltool-extract are marked by N_ function, which is now \
> added to the list of keywords recognized by xgettext. Other keywords are still \
> recognized. 
> 
> Diffs
> -----
> 
> Messages.sh 67d0db4 
> 
> Diff: https://git.reviewboard.kde.org/r/126496/diff/
> 
> 
> Testing
> -------
> 
> Tested extraction with extract-messages.sh; messages from .h/.cpp files not marked \
> by *i18n are not extracted anymore, while messages handled from intltools-extract \
> are still extracted. 
> 
> Thanks,
> 
> Luigi Toscano
> 
> 


--===============1251162115801639046==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126496/">https://git.reviewboard.kde.org/r/126496/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />









<p>- Albert Astals Cid</p>


<br />
<p>On desembre 24th, 2015, 12:27 a.m. UTC, Luigi Toscano wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Localization and Translation (l10n) and Martin \
Klapetek.</div> <div>By Luigi Toscano.</div>


<p style="color: grey;"><i>Updated des. 24, 2015, 12:27 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kaccounts-providers
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Previously all strings were extracted (see review 120618), but it is not \
possible to blindly extract all strings now because the repository contains also \
code. The messages extracted by intltool-extract are marked by N_ function, which is \
now added to the list of keywords recognized by xgettext. Other keywords are still \
recognized.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested extraction with extract-messages.sh; messages from .h/.cpp files \
not marked by *i18n are not extracted anymore, while messages handled from \
intltools-extract are still extracted.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>Messages.sh <span style="color: grey">(67d0db4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126496/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============1251162115801639046==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic