[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 125561: Align FindGettext with CMP002 policy
From: "Alexander Semke" <alexander.semke () web ! de>
Date: 2015-10-10 14:24:54
Message-ID: 20151010142454.17685.21490 () mimi ! kde ! org
[Download RAW message or body]
--===============8511417341197778346==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 10, 2015, 12:40 p.m., Alexander Semke wrote:
> > Sholdn't the proposed patch in \
> > https://bugs.kde.org/show_bug.cgi?id=293030 already fix the problem?
>
> Hrvoje Senjan wrote:
> Which patch? I only see the whole file there.
Yes, I see the complete file only, too. The relevant fix is supposed to be \
included there.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125561/#review86622
-----------------------------------------------------------
On Oct. 10, 2015, 2:05 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125561/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2015, 2:05 p.m.)
>
>
> Review request for Build System, kdelibs, Localization and Translation \
> (l10n), Albert Astals Cid, and Alexander Neundorf.
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Otherwise some apps fail to build with kdelibs >= 4.14.11:
> ```
> CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 \
> (ADD_CUSTOM_TARGET): add_custom_target cannot create target "pofiles" \
> because another target with the same name already exists. The existing \
> target is a custom target created in source directory
> "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for
> policy CMP0002 for more details.
> Call Stack (most recent call first):
> po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES)
> ```
>
>
> Diffs
> -----
>
> cmake/modules/FindGettext.cmake 91e88f7
>
> Diff: https://git.reviewboard.kde.org/r/125561/diff/
>
>
> Testing
> -------
>
> Skanlite now builds.
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
--===============8511417341197778346==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125561/">https://git.reviewboard.kde.org/r/125561/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On October 10th, 2015, \
12:40 p.m. UTC, <b>Alexander Semke</b> wrote:</p> <blockquote \
style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Sholdn't the proposed patch \
in https://bugs.kde.org/show_bug.cgi?id=293030 already fix the \
problem?</p></pre> </blockquote>
<p>On October 10th, 2015, 12:52 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Which patch? I only see the \
whole file there.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Yes, I see the complete file only, too. The \
relevant fix is supposed to be included there.</p></pre> <br />
<p>- Alexander</p>
<br />
<p>On October 10th, 2015, 2:05 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, kdelibs, Localization and Translation \
(l10n), Albert Astals Cid, and Alexander Neundorf.</div> <div>By Hrvoje \
Senjan.</div>
<p style="color: grey;"><i>Updated Oct. 10, 2015, 2:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Otherwise some apps fail to \
build with kdelibs >= 4.14.11:</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: \
125%">CMake Error at \
/usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 \
(ADD_CUSTOM_TARGET): add_custom_target cannot create target \
"pofiles" because another target with the same name already \
exists. The existing target is a custom target created in source \
directory "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See \
documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES)
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Skanlite now \
builds.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindGettext.cmake <span style="color: \
grey">(91e88f7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125561/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8511417341197778346==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic