From kde-i18n-doc Sat Oct 10 14:24:54 2015 From: "Alexander Semke" Date: Sat, 10 Oct 2015 14:24:54 +0000 To: kde-i18n-doc Subject: Re: Review Request 125561: Align FindGettext with CMP002 policy Message-Id: <20151010142454.17685.21490 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-i18n-doc&m=144448714726634 --===============8511417341197778346== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 10, 2015, 12:40 p.m., Alexander Semke wrote: > > Sholdn't the proposed patch in https://bugs.kde.org/show_bug.cgi?id=293030 already fix the problem? > > Hrvoje Senjan wrote: > Which patch? I only see the whole file there. Yes, I see the complete file only, too. The relevant fix is supposed to be included there. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86622 ----------------------------------------------------------- On Oct. 10, 2015, 2:05 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125561/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2015, 2:05 p.m.) > > > Review request for Build System, kdelibs, Localization and Translation (l10n), Albert Astals Cid, and Alexander Neundorf. > > > Repository: kdelibs > > > Description > ------- > > Otherwise some apps fail to build with kdelibs >= 4.14.11: > ``` > CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 (ADD_CUSTOM_TARGET): > add_custom_target cannot create target "pofiles" because another target > with the same name already exists. The existing target is a custom target > created in source directory > "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for > policy CMP0002 for more details. > Call Stack (most recent call first): > po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES) > ``` > > > Diffs > ----- > > cmake/modules/FindGettext.cmake 91e88f7 > > Diff: https://git.reviewboard.kde.org/r/125561/diff/ > > > Testing > ------- > > Skanlite now builds. > > > Thanks, > > Hrvoje Senjan > > --===============8511417341197778346== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/

On October 10th, 2015, 12:40 p.m. UTC, Alexander Semke wrote:
Sholdn't the proposed patch in https://bugs.kde.org/show_bug.cgi?id=293030 already fix the problem?
On October 10th, 2015, 12:52 p.m. UTC, Hrvoje Senjan wrote:
Which patch? I only see the whole file there.

Yes, I see the complete file only, too. The relevant fix is supposed to be included there.

- Alexander

On October 10th, 2015, 2:05 p.m. UTC, Hrvoje Senjan wrote:

Review request for Build System, kdelibs, Localization and Translation (l10n), Albert Astals Cid, and Alexander Neundorf.

By Hrvoje Senjan.

Updated Oct. 10, 2015, 2:05 p.m.

Repository: kdelibs

Description

Otherwise some apps fail to build with kdelibs >= 4.14.11:

CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 (ADD_CUSTOM_TARGET):
  add_custom_target cannot create target "pofiles" because another target
  with the same name already exists.  The existing target is a custom target
  created in source directory
  "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be".  See documentation for
  policy CMP0002 for more details.
Call Stack (most recent call first):
  po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES)

Testing

Skanlite now builds.

Diffs

cmake/modules/FindGettext.cmake (91e88f7)

--===============8511417341197778346==--