[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: String freeze exception (and review request) for Plasma 5.2
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2015-01-10 22:20:19
Message-ID: 6261840.HiXxieFD3B () xps
[Download RAW message or body]

El Divendres, 9 de gener de 2015, a les 18:23:20, Safa Alfulaij va escriure:
> It is good, But I tink that it's better to return the string in each if
> statement, I mean putting the "dir"/"dirs" in the "%1 of %2 %3" like this:

You should be commenting in reviewboard, that's the point of it ;)

Cheers,
  Albert

> 
>              if (unit === "files") {
> 
> >                 // this needs using i18np because some languages have
> >> 
> >> different plural forms for different numbers
> >> 
> >                 return i18ncp("m of n files are being processed", "%1 of
> >> 
> >> %2 file", "%1 of %2 files", processed, total)
> >> 
> >              } else if (unit === "dirs") {
> >              
> >                 // this needs using i18np because some languages have
> >> 
> >> different plural forms for different numbers
> >> 
> >                 return i18ncp("m of n dirs are being processed", "%1 of
> >> 
> >> %2 dir", "%1 of %2 dirs", processed, total)
> >> 
> >              }
> >              
> >              
> >              
> >              return i18n("%1 of %2 %3", processed, total, unit)
> 
> And leave the last as a fallback :)
> 
> Regards
> 
> 2015-01-09 17:01 GMT+03:00 Yuri Chornoivan <yurchor@ukr.net>:
> > написане Fri, 09 Jan 2015 15:57:47 +0200, Martin Klapetek <
> > 
> > martin.klapetek@gmail.com>:
> >  Hey all,
> >  
> >> so yesterday Safa pointed out here that we're using non-plural i18n for
> >> units in Plasma's job tracker. Yesterday was also the string freeze for
> >> Plasma 5.2.
> >> 
> >> I fixed it with https://git.reviewboard.kde.org/r/121945/ and would like
> >> to
> >> ask you guys for a review and an exception for the string freeze. I think
> >> this would be cool to have for 5.2.
> >> 
> >> Cheers
> > 
> > Hi,
> > 
> > No objections from Ukrainian team.
> > 
> > Best regards,
> > Yuri

[prev in list] [next in list] [prev in thread] [next in thread]