El Divendres, 9 de gener de 2015, a les 18:23:20, Safa Alfulaij va escr=
iure:
> It is good, But I tink that it's better to return the string in each =
if
> statement, I mean putting the "dir"/"dirs" in the "%1 of %2 %3" like =
this:

You should be commenting in reviewboard, that's the point of it ;)

Cheers,
  Albert

>=20
>              if (unit =3D=3D=3D "files") {
>=20
> >                 // this needs using i18np because some languages ha=
ve
> >>=20
> >> different plural forms for different numbers
> >>=20
> >                 return i18ncp("m of n files are being processed", "=
%1 of
> >>=20
> >> %2 file", "%1 of %2 files", processed, total)
> >>=20
> >              } else if (unit =3D=3D=3D "dirs") {
> >             =20
> >                 // this needs using i18np because some languages ha=
ve
> >>=20
> >> different plural forms for different numbers
> >>=20
> >                 return i18ncp("m of n dirs are being processed", "%=
1 of
> >>=20
> >> %2 dir", "%1 of %2 dirs", processed, total)
> >>=20
> >              }
> >             =20
> >             =20
> >             =20
> >              return i18n("%1 of %2 %3", processed, total, unit)
>=20
> And leave the last as a fallback :)
>=20
> Regards
>=20
> 2015-01-09 17:01 GMT+03:00 Yuri Chornoivan <yurchor@ukr.net>:
> > =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BD=D0=B5 Fri, 09 Jan 2015 1=
5:57:47 +0200, Martin Klapetek <
> >=20
> > martin.klapetek@gmail.com>:
> >  Hey all,
> > =20
> >> so yesterday Safa pointed out here that we're using non-plural i18=
n for
> >> units in Plasma's job tracker. Yesterday was also the string freez=
e for
> >> Plasma 5.2.
> >>=20
> >> I fixed it with https://git.reviewboard.kde.org/r/121945/ and woul=
d like
> >> to
> >> ask you guys for a review and an exception for the string freeze. =
I think
> >> this would be cool to have for 5.2.
> >>=20
> >> Cheers
> >=20
> > Hi,
> >=20
> > No objections from Ukrainian team.
> >=20
> > Best regards,
> > Yuri