[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: [PATCH] Port autogen.sh to ECM
From:       Burkhard =?ISO-8859-1?Q?L=FCck?= <lueck () hube-lueck ! de>
Date:       2014-04-14 19:48:08
Message-ID: 1643391.k8z6jMasVQ () parodia
[Download RAW message or body]

Am Montag, 14. April 2014, 13:12:30 schrieb Aurélien Gâteau:
> Hi,
> 
> Attached patch ports l1On-kf5/scripts/autogen.sh to ECM.
> 
> For the sake of simplification, I replaced calls to
> macro_optional_add_subdirectory() with calls to add_subdirectory() since the
> code generating the CMakeLists.txt checks the directory exists before
> adding an add_subdirectory()" call.
> 
> I tested it with a handful of messages and doc .po. There is an issue with
> doc installation failing to create a "common" symlink, but the problem needs
> to be fixed in kdoctools as far as I understand.
> 
Please commit

> Assuming this patch is OK for you, would you mind if I also create a
> separate commit to fix the indentation? The current inconsistent mix of tabs
> and spaces makes it annoying to work with.
> 
OK.

Thanks for your work

-- 
Burkhard Lück

[prev in list] [next in list] [prev in thread] [next in thread]