[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: [ktp-presence-applet] /: Move the applet to ktp-desktop-applets (ktp-contact-applet) repository
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2013-01-14 19:36:48
Message-ID: 1962847.BqWSqGfUBf () xps
[Download RAW message or body]

El Dilluns, 14 de gener de 2013, a les 16:45:36, Daniel Vrátil va escriure:
> On Sunday 13 of January 2013 17:50:33 Burkhard Lück wrote:
> > Am Samstag, 12. Januar 2013, 18:59:41 schrieb Dan Vrátil:
> > > Git commit 7fc0dccf80fd332a6e4477cfefad8f11ee452310 by Dan Vrátil.
> > > Committed on 12/01/2013 at 18:58.
> > > Pushed by dvratil into branch 'master'.
> > > 
> > > Move the applet to ktp-desktop-applets (ktp-contact-applet) repository
> > > 
> > > D  +0    -46   CMakeLists.txt
> > > D  +0    -502  COPYING
> > > D  +0    -4    Messages.sh
> > > A  +3    -0    README
> > > D  +0    -22   cmake/modules/COPYING-CMAKE-SCRIPTS
> > > D  +0    -38   cmake/modules/FindKTp.cmake
> > > D  +0    -55   plasma_applet_ktp_presence.desktop
> > > D  +0    -347  src/presenceapplet.cpp
> > > D  +0    -90   src/presenceapplet.h
> > > 
> > > http://commits.kde.org/telepathy-presence-applet/7fc0dccf80fd332a6e4477c
> > > fe
> > > fa d8f11ee452310
> > 
> > I see two issues with your move:
> > 
> > 1) You lost the Messages.sh, please readd it
> 
> Just out of curiosity - why do we have to keep Messages.sh in an empty
> folder?

I guess Burkhard meant \
http://commits.kde.org/telepathy-contact-applet/a4c3fd5a3ccd0ff5097fc88cb25784dc44dd6e03 \
?

It's not empty, is it?

> > 2) Old Messages.sh extracted to the catalog
> > "plasma_applet_ktp_presence.pot", but presence-applet.cpp has the macro
> > K_EXPORT_PLASMA_APPLET(org.kde.ktp- presence, TelepathyPresenceApplet),
> > which afaik means at runtime the applet tries to load the not existing
> > catalod plasma_applet_TelepathyPresenceApplet.
> 
> Hmm, strace indicates that the catalog is called plasma_applet_org.kde.ktp-
> presence:
> 
> access("/usr/share/locale/en_US/LC_SCRIPTS/plasma_applet_org.kde.ktp-
> presence/plasma_applet_org.kde.ktp-presence.js .....)
> 
> I'm not really an expert in this, could someone from the i18n team shed some
> light on this?

Why should someone on the i18n team shed light on this? Shouldn't this be documented \
as general programming of plasmoids?

Anyway yes, Burkhard got confused in K_EXPORT_PLASMA_APPLET the first is the \
"component name" and the second is the name of the C++ class so \
plasma_applet_ktp_presence.pot is wrong, but plasma_applet_TelepathyPresenceApplet is \
not the correct one, plasma_applet_org.kde.ktp-presence is the correct one.

Cheers,
  Albert

> 
> Thanks
> 
> Dan


[prev in list] [next in list] [prev in thread] [next in thread]