[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Re: Question about a string SOCKS for FTP?
From:       Frederik Schwarzer <schwarzer () kde ! org>
Date:       2011-11-24 1:51:52
Message-ID: 10579501.VzAHVumxQQ () tamaki
[Download RAW message or body]

Thursday 24 November 2011 [Albert Astals Cid]:
> El Dimarts, 22 de novembre de 2011, a les 17:23:28, Dawit A va escriure:
> > On Mon, Nov 21, 2011 at 5:51 PM, Albert Astals Cid <aacid@kde.org> wrote:
> > > A Dilluns, 21 de novembre de 2011, Dawit A v�reu escriure:
> > >> On Sun, Nov 20, 2011 at 11:42 AM, Burkhard L�ck <lueck@hube-lueck.de> 
> wrote:
> > >> > Am Samstag, 19. November 2011, 18:01:21 schrieb Frederik Schwarzer:
> > >> >> (ok, quote on reply is gone ...)
> > >> >> 
> > >> >> I am not sure. Your first change looks fishy. The name of the
> > >> >> widget
> > >> >> is
> > >> >> systemProxyHttpsLabel and you change the test to SSL.
> > >> > 
> > >> > You are right, apparently I got confused by the field label SSL,
> > >> > shouldn't that be something like HTTPS (SSL) Proxy to be
> > >> > consistent
> > >> > with the other labels?
> > >> > 
> > >> > Fixed patch attached.
> > >> 
> > >> Hmm... the attached patch and the question do not match ?? Anyhow, the
> > >> answer to the question is it should be either HTTPS or SSL not both. I
> > >> chose to change it to "SSL" because Firefox's proxy configuration
> > >> chooses to use that as a label and I saw no reason why we should use
> > >> different labeling. What I forgot to do is update the variable names
> > >> assigned to those two radiobuttons in the UI file to reflect this
> > >> change.
> > > 
> > > Dawit, there is an updated patch at
> > > http://lists.kde.org/?l=kde-i18n-doc&m=132187717630659&q=p3
> > > 
> > > Can you have a look at it?
> > 
> > I do not see anything objectionable to that patch. However, I was not
> > able to apply it and test it against my local copy kde-baseapps
> > because it does not apply using git apply.
> 
> Can someone please apply it?
> 
> Frederik?

Ah, sorry. I already applied it yesterday. Forgot to report back.

Regards
[prev in list] [next in list] [prev in thread] [next in thread]