[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Request for permission to commit a string changing bugfix to
From:       Till Adam <till () adam-lilienthal ! de>
Date:       2003-04-29 5:13:37
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 28 April 2003 22:51, Grisha Mokhin wrote:
> TA> the attached patch keeps kmail from blocking all further messages in
> the TA> outbox when sending one message fails. This is already in head but
> I've been TA> asked to backport it and commit it, provided you guys ok the
> commit, as it TA> changes strings (albeit only a little).
>
> Please note that this patch breaks plural forms. Have a look at the
> first i18n'd string, where %n means plural forms handling:
>
> +    if (someSent) {
> +      if ( mSentMessages == mTotalMessages ) {
> +        setStatusMsg(i18n("%n queued message successfully sent.",
> +                 "%n queued messages successfully sent.",
> +                 mSentMessages));
> +      } else {
> +        setStatusMsg(i18n("%1 of %2 queued messages successfully sent.")
> +            .arg(mSentMessages).arg( mTotalMessages ));

I'm sorry, I don't understand. I've copied the use of %n from the exisiting 
code. How is it wrong?

Till
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+rgoBtrsWGirveVsRAgSlAKDMMob5Aj6F2vpHYBtao28tJ1B8FwCdHYSq
4B2/oL/Ae3/gCYdKO66Zpc8=
=MgaI
-----END PGP SIGNATURE-----


[prev in list] [next in list] [prev in thread] [next in thread]