'Re: [Kde-graphics-devel] Review Request 122737: Re-origanise code in the frameworks branch'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-graphics-devel
Subject:    Re: [Kde-graphics-devel] Review Request 122737: Re-origanise code in the frameworks branch
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2015-02-27 19:51:37
Message-ID: 20150227195137.12884.37479 () probe ! kde ! org
[Download RAW message or body]

--===============1341978631301969842==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122737/#review76743
-----------------------------------------------------------

Ship it!

Ship It!

- Aaron J. Seigo

On Feb. 27, 2015, 7:06 p.m., Boudhayan Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122737/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2015, 7:06 p.m.)
> 
> 
> Review request for KSnapshot and Aleix Pol Gonzalez.
> 
> 
> Repository: ksnapshot
> 
> 
> Description
> -------
> 
> This is a pretty big patch. It does the following:
> 
> * Move all the .cpp and .h files to an "src" directory
> * Move the XDG desktop file to a "desktop" directory
> * Move the SVG icon source for the hicolor icon to the icons directory
> * Refactor the CMakeLists.txt file
> * Give each subdirectory (src, icons, desktop) its own CMakeLists.txt. doc already \
>                 had one.
> * Guard config-ksnapshot.h.cmake contents within ifndef-define-endif preprocessor \
>                 directives
> * Move the KSNAPVERSION define from main.cpp to config-ksnapshot.h.cmake
> * The KSnapshot version is now defined in the top-level CMakeLists.txt
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt d174abf 
> Messages-i18n.sh PRE-CREATION 
> Messages-qt.sh PRE-CREATION 
> Messages.sh d242e38 
> config-ksnapshot.h.cmake 3514dd5 
> main.cpp ef03554 
> 
> Diff: https://git.reviewboard.kde.org/r/122737/diff/
> 
> 
> Testing
> -------
> 
> Builds and installs fine. No functionality was added in this patch, so didn't test \
> much beyond build/run/take screenshots. 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
> 

--===============1341978631301969842==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122737/">https://git.reviewboard.kde.org/r/122737/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aaron J. Seigo</p>

<br />
<p>On February 27th, 2015, 7:06 p.m. UTC, Boudhayan Gupta wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KSnapshot and Aleix Pol Gonzalez.</div>
<div>By Boudhayan Gupta.</div>

<p style="color: grey;"><i>Updated Feb. 27, 2015, 7:06 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnapshot
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a pretty big patch. It does the following:</p> \
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Move all the .cpp and .h files to an \
"src" directory</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Move the XDG desktop file to a "desktop" \
directory</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Move the SVG icon source for the hicolor icon to the \
icons directory</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Refactor the CMakeLists.txt file</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Give each subdirectory (src, icons, desktop) its own \
CMakeLists.txt. doc already had one.</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Guard \
config-ksnapshot.h.cmake contents within ifndef-define-endif preprocessor \
directives</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Move the KSNAPVERSION define from main.cpp to \
config-ksnapshot.h.cmake</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">The KSnapshot version is now defined in \
the top-level CMakeLists.txt</li> </ul></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds and installs fine. No functionality was added \
in this patch, so didn't test much beyond build/run/take screenshots.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(d174abf)</span></li>

 <li>Messages-i18n.sh <span style="color: grey">(PRE-CREATION)</span></li>

 <li>Messages-qt.sh <span style="color: grey">(PRE-CREATION)</span></li>

 <li>Messages.sh <span style="color: grey">(d242e38)</span></li>

 <li>config-ksnapshot.h.cmake <span style="color: grey">(3514dd5)</span></li>

 <li>main.cpp <span style="color: grey">(ef03554)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122737/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1341978631301969842==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-graphics-devel mailing list
Kde-graphics-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-graphics-devel

[prev in list] [next in list] [prev in thread] [next in thread] 