--===============3460564389188593600== Content-Type: multipart/alternative; boundary="===============1341978631301969842==" --===============1341978631301969842== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122737/#review76743 ----------------------------------------------------------- Ship it! Ship It! - Aaron J. Seigo On Feb. 27, 2015, 7:06 p.m., Boudhayan Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122737/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 7:06 p.m.) > > > Review request for KSnapshot and Aleix Pol Gonzalez. > > > Repository: ksnapshot > > > Description > ------- > > This is a pretty big patch. It does the following: > > * Move all the .cpp and .h files to an "src" directory > * Move the XDG desktop file to a "desktop" directory > * Move the SVG icon source for the hicolor icon to the icons directory > * Refactor the CMakeLists.txt file > * Give each subdirectory (src, icons, desktop) its own CMakeLists.txt. doc already had one. > * Guard config-ksnapshot.h.cmake contents within ifndef-define-endif preprocessor directives > * Move the KSNAPVERSION define from main.cpp to config-ksnapshot.h.cmake > * The KSnapshot version is now defined in the top-level CMakeLists.txt > > > Diffs > ----- > > CMakeLists.txt d174abf > Messages-i18n.sh PRE-CREATION > Messages-qt.sh PRE-CREATION > Messages.sh d242e38 > config-ksnapshot.h.cmake 3514dd5 > main.cpp ef03554 > > Diff: https://git.reviewboard.kde.org/r/122737/diff/ > > > Testing > ------- > > Builds and installs fine. No functionality was added in this patch, so didn't test much beyond build/run/take screenshots. > > > Thanks, > > Boudhayan Gupta > > --===============1341978631301969842== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122737/

Ship it!

Ship It!

- Aaron J. Seigo

On February 27th, 2015, 7:06 p.m. UTC, Boudhayan Gupta wrote:

Review request for KSnapshot and Aleix Pol Gonzalez.

By Boudhayan Gupta.

Updated Feb. 27, 2015, 7:06 p.m.

Repository: ksnapshot

Description

This is a pretty big patch. It does the following:

Move all the .cpp and .h files to an "src" directory
Move the XDG desktop file to a "desktop" directory
Move the SVG icon source for the hicolor icon to the icons directory
Refactor the CMakeLists.txt file
Give each subdirectory (src, icons, desktop) its own CMakeLists.txt. doc already had one.
Guard config-ksnapshot.h.cmake contents within ifndef-define-endif preprocessor directives
Move the KSNAPVERSION define from main.cpp to config-ksnapshot.h.cmake
The KSnapshot version is now defined in the top-level CMakeLists.txt

Testing

Builds and installs fine. No functionality was added in this patch, so didn't test much beyond build/run/take screenshots.

Diffs

CMakeLists.txt (d174abf)
Messages-i18n.sh (PRE-CREATION)
Messages-qt.sh (PRE-CREATION)
Messages.sh (d242e38)
config-ksnapshot.h.cmake (3514dd5)
main.cpp (ef03554)

--===============1341978631301969842==-- --===============3460564389188593600== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWdyYXBo aWNzLWRldmVsIG1haWxpbmcgbGlzdApLZGUtZ3JhcGhpY3MtZGV2ZWxAa2RlLm9yZwpodHRwczov L21haWwua2RlLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tkZS1ncmFwaGljcy1kZXZlbAo= --===============3460564389188593600==--