[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: Catastrophic failure in KSudoku
From: Jeremy Whiting <jpwhiting () kde ! org>
Date: 2019-03-20 16:06:25
Message-ID: CADWV2K5DJMVrGQuGT68db5Yz=oB4fos4wKJe7ePO_Ye-=hKcfg () mail ! gmail ! com
[Download RAW message or body]
Ok, merged to master and Applications/19.04.
On Wed, Mar 20, 2019 at 4:25 AM Ian Wadham <iandw.au@gmail.com> wrote:
> Hi Luigi,
>
> > On 20 Mar 2019, at 6:37 pm, Luigi Toscano <luigi.toscano@tiscali.it>
> wrote:
> >
> > Ian Wadham ha scritto:
> >>> On 20 Mar 2019, at 1:28 pm, Jeremy Whiting <jpwhiting@kde.org> wrote:
> >>>
> >>> Hi Ian,
> >>>
> >>> Awesome. I've pushed the patch to git here:
> https://cgit.kde.org/ksudoku.git/commit/?id=40e80d73866634c954dce212f2da43cd0fdce8d6
> feel free to merge to master if you're good with it. I think the
> applications freeze is coming up in a couple of days though from looking at
> https://community.kde.org/Schedules/Applications/19.04_Release_Schedule
> I'm happy to push to master if you're not set up to do it also, let me know.
> >> Yes please. Please do all the necessary commits, merges, pushes or
> whatever. I am not set up for that and my knowledge of git is extremely
> rusty.
> >
> > Before removing code without knowing the reason
>
> How do you mean "reason" in this context?
>
> 1. A problem with the selection of library versions for Qt 5 and KF5?
> 2. A problem with the lines of code in KSudoku that Jeremy and I
> propose to remove?
>
> Re 2, the code that copies an XML file to a temp file before parsing it is
> obsolescent and redundant
> and is quite safe to remove, for reasons I have given in an earlier email
> on this thread.
>
> I speak as the most recent maintainer/developer of KSudoku. The XML files
> involved have been
> read-only and local for at least 10 years, so no need to copy to a temp
> file.
>
> > and merging commits, did you see Albert's question? Maybe this was
> solved in Qt, or it can be solved in a different way. I don't see the
> problem either with Qt 5.11.3.
>
> Duncan, the original reporter of
> https://bugs.kde.org/show_bug.cgi?id=405422, has told me by a
> private email that he uses Qt 5.12.2, which is 0.0.1 ahead of what Albert
> uses. And you, Luigi, are
> using Qt 5.11.3, same as Jeremy, yoet he gets the bug and you don't.
>
> Perhaps the problem is not in Qt 5 at all, Perhaps it is in some version
> of KF5 (Frameworks), eg. in
> KIO::FileCopyJob. Not that Albert had success with KF5 5.56. What other
> versions are around?
>
> I have asked Duncan to post details of his findings on bugzilla, so that
> we can all see them.
>
> After all, maybe other apps will be affected if there are problems in Qt 5
> or KF5 and maybe
> KSudoku is the canary in the coal-mine.
>
> And there IS a release of KDE Applications imminent.
>
> Best regards,
> Ian W.
>
> >
> > --
> > Luigi
>
>
[Attachment #3 (text/html)]
<div dir="ltr">Ok, merged to master and Applications/19.04.<br></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 20, 2019 at 4:25 AM \
Ian Wadham <<a href="mailto:iandw.au@gmail.com">iandw.au@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Luigi,<br> <br>
> On 20 Mar 2019, at 6:37 pm, Luigi Toscano <<a \
href="mailto:luigi.toscano@tiscali.it" \
target="_blank">luigi.toscano@tiscali.it</a>> wrote:<br> > <br>
> Ian Wadham ha scritto:<br>
>>> On 20 Mar 2019, at 1:28 pm, Jeremy Whiting <<a \
href="mailto:jpwhiting@kde.org" target="_blank">jpwhiting@kde.org</a>> wrote:<br> \
>>> <br> >>> Hi Ian,<br>
>>> <br>
>>> Awesome. I've pushed the patch to git here: <a \
href="https://cgit.kde.org/ksudoku.git/commit/?id=40e80d73866634c954dce212f2da43cd0fdce8d6" \
rel="noreferrer" target="_blank">https://cgit.kde.org/ksudoku.git/commit/?id=40e80d73866634c954dce212f2da43cd0fdce8d6</a> \
feel free to merge to master if you're good with it. I think the applications \
freeze is coming up in a couple of days though from looking at <a \
href="https://community.kde.org/Schedules/Applications/19.04_Release_Schedule" \
rel="noreferrer" target="_blank">https://community.kde.org/Schedules/Applications/19.04_Release_Schedule</a> \
I'm happy to push to master if you're not set up to do it also, let me \
know.<br> >> Yes please. Please do all the necessary commits, merges, pushes or \
whatever. I am not set up for that and my knowledge of git is extremely rusty.<br> \
> <br> > Before removing code without knowing the reason<br>
<br>
How do you mean "reason" in this context?<br>
<br>
1. A problem with the selection of library versions for Qt 5 and KF5?<br>
2. A problem with the lines of code in KSudoku that Jeremy and I propose to \
remove?<br> <br>
Re 2, the code that copies an XML file to a temp file before parsing it is \
obsolescent and redundant<br> and is quite safe to remove, for reasons I have given \
in an earlier email on this thread.<br> <br>
I speak as the most recent maintainer/developer of KSudoku. The XML files involved \
have been<br> read-only and local for at least 10 years, so no need to copy to a temp \
file.<br> <br>
> and merging commits, did you see Albert's question? Maybe this was solved in \
Qt, or it can be solved in a different way. I don't see the problem either with \
Qt 5.11.3.<br> <br>
Duncan, the original reporter of <a \
href="https://bugs.kde.org/show_bug.cgi?id=405422" rel="noreferrer" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=405422</a>, has told me by a<br> \
private email that he uses Qt 5.12.2, which is 0.0.1 ahead of what Albert uses. And \
you, Luigi, are<br> using Qt 5.11.3, same as Jeremy, yoet he gets the bug and you \
don't.<br> <br>
Perhaps the problem is not in Qt 5 at all, Perhaps it is in some version of KF5 \
(Frameworks), eg. in<br> KIO::FileCopyJob. Not that Albert had success with KF5 5.56. \
What other versions are around?<br> <br>
I have asked Duncan to post details of his findings on bugzilla, so that we can all \
see them.<br> <br>
After all, maybe other apps will be affected if there are problems in Qt 5 or KF5 and \
maybe<br> KSudoku is the canary in the coal-mine.<br>
<br>
And there IS a release of KDE Applications imminent.<br>
<br>
Best regards,<br>
Ian W.<br>
<br>
> <br>
> -- <br>
> Luigi<br>
<br>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic