From kde-games-devel Wed Mar 20 16:06:25 2019 From: Jeremy Whiting Date: Wed, 20 Mar 2019 16:06:25 +0000 To: kde-games-devel Subject: Re: Catastrophic failure in KSudoku Message-Id: X-MARC-Message: https://marc.info/?l=kde-games-devel&m=155309801007496 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--00000000000077b85e058488ce57" --00000000000077b85e058488ce57 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ok, merged to master and Applications/19.04. On Wed, Mar 20, 2019 at 4:25 AM Ian Wadham wrote: > Hi Luigi, > > > On 20 Mar 2019, at 6:37 pm, Luigi Toscano > wrote: > > > > Ian Wadham ha scritto: > >>> On 20 Mar 2019, at 1:28 pm, Jeremy Whiting wrote: > >>> > >>> Hi Ian, > >>> > >>> Awesome. I've pushed the patch to git here: > https://cgit.kde.org/ksudoku.git/commit/?id=3D40e80d73866634c954dce212f2d= a43cd0fdce8d6 > feel free to merge to master if you're good with it. I think the > applications freeze is coming up in a couple of days though from looking = at > https://community.kde.org/Schedules/Applications/19.04_Release_Schedule > I'm happy to push to master if you're not set up to do it also, let me kn= ow. > >> Yes please. Please do all the necessary commits, merges, pushes or > whatever. I am not set up for that and my knowledge of git is extremely > rusty. > > > > Before removing code without knowing the reason > > How do you mean =E2=80=9Creason=E2=80=9D in this context? > > 1. A problem with the selection of library versions for Qt 5 and KF5? > 2. A problem with the lines of code in KSudoku that Jeremy and I > propose to remove? > > Re 2, the code that copies an XML file to a temp file before parsing it i= s > obsolescent and redundant > and is quite safe to remove, for reasons I have given in an earlier email > on this thread. > > I speak as the most recent maintainer/developer of KSudoku. The XML files > involved have been > read-only and local for at least 10 years, so no need to copy to a temp > file. > > > and merging commits, did you see Albert's question? Maybe this was > solved in Qt, or it can be solved in a different way. I don't see the > problem either with Qt 5.11.3. > > Duncan, the original reporter of > https://bugs.kde.org/show_bug.cgi?id=3D405422, has told me by a > private email that he uses Qt 5.12.2, which is 0.0.1 ahead of what Albert > uses. And you, Luigi, are > using Qt 5.11.3, same as Jeremy, yoet he gets the bug and you don=E2=80= =99t. > > Perhaps the problem is not in Qt 5 at all, Perhaps it is in some version > of KF5 (Frameworks), eg. in > KIO::FileCopyJob. Not that Albert had success with KF5 5.56. What other > versions are around? > > I have asked Duncan to post details of his findings on bugzilla, so that > we can all see them. > > After all, maybe other apps will be affected if there are problems in Qt = 5 > or KF5 and maybe > KSudoku is the canary in the coal-mine. > > And there IS a release of KDE Applications imminent. > > Best regards, > Ian W. > > > > > -- > > Luigi > > --00000000000077b85e058488ce57 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok, merged to master and Applications/19.04.

=
On Wed, Ma= r 20, 2019 at 4:25 AM Ian Wadham <= iandw.au@gmail.com> wrote:
Hi Luigi,

> On 20 Mar 2019, at 6:37 pm, Luigi Toscano <luigi.toscano@tiscali.it> wrot= e:
>
> Ian Wadham ha scritto:
>>> On 20 Mar 2019, at 1:28 pm, Jeremy Whiting <jpwhiting@kde.org> wrote: >>>
>>> Hi Ian,
>>>
>>> Awesome. I've pushed the patch to git here: https://cgit.kde.org/ksudoku= .git/commit/?id=3D40e80d73866634c954dce212f2da43cd0fdce8d6 feel free to= merge to master if you're good with it. I think the applications freez= e is coming up in a couple of days though from looking at https://community.kde.org/Schedules/Applicatio= ns/19.04_Release_Schedule I'm happy to push to master if you're= not set up to do it also, let me know.
>> Yes please. Please do all the necessary commits, merges, pushes or= whatever. I am not set up for that and my knowledge of git is extremely ru= sty.
>
> Before removing code without knowing the reason

How do you mean =E2=80=9Creason=E2=80=9D in this context?

=C2=A0 =C2=A01. A problem with the selection of library versions for Qt 5 a= nd KF5?
=C2=A0 =C2=A02. A problem with the lines of code in KSudoku that Jeremy and= I propose to remove?

Re 2, the code that copies an XML file to a temp file before parsing it is = obsolescent and redundant
and is quite safe to remove, for reasons I have given in an earlier email o= n this thread.

I speak as the most recent maintainer/developer of KSudoku. The XML files i= nvolved have been
read-only and local for at least 10 years, so no need to copy to a temp fil= e.

> and merging commits, did you see Albert's question? Maybe this was= solved in Qt, or it can be solved in a different way. I don't see the = problem either with Qt 5.11.3.

Duncan, the original reporter of https://bugs.kde.org/s= how_bug.cgi?id=3D405422, has told me by a
private email that he uses Qt 5.12.2, which is 0.0.1 ahead of what Albert u= ses. And you, Luigi, are
using Qt 5.11.3, same as Jeremy, yoet he gets the bug and you don=E2=80=99t= .

Perhaps the problem is not in Qt 5 at all, Perhaps it is in some version of= KF5 (Frameworks), eg. in
KIO::FileCopyJob. Not that Albert had success with KF5 5.56. What other ver= sions are around?

I have asked Duncan to post details of his findings on bugzilla, so that we= can all see them.

After all, maybe other apps will be affected if there are problems in Qt 5 = or KF5 and maybe
KSudoku is the canary in the coal-mine.

And there IS a release of KDE Applications imminent.

Best regards,
Ian W.

>
> --
> Luigi

--00000000000077b85e058488ce57--