[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 125506: marking the last move
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2015-11-30 22:13:23
Message-ID: 20151130221323.29696.79246 () mimi ! kde ! org
[Download RAW message or body]
--===============0275360199124896203==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On oct. 28, 2015, 11:07 p.m., Albert Astals Cid wrote:
> > Sascha hasn't done any commit since 2010, so this is one of the manu unmaintened \
> > stuff we have.
> > If you really think this is a good thing, commit it (maybe wait a few more weeks \
> > in case anyone else bothers to comment)
Michal do you plan to commit this or what?
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125506/#review87630
-----------------------------------------------------------
On oct. 3, 2015, 2:45 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125506/
> -----------------------------------------------------------
>
> (Updated oct. 3, 2015, 2:45 p.m.)
>
>
> Review request for KDE Games and Sascha Peilicke.
>
>
> Repository: kigo
>
>
> Description
> -------
>
> Because there is no animation for move, it's not immediately clear where the \
> oponent played. This patch adds a second stone type which is used for the last \
> move.
>
> Diffs
> -----
>
> data/themes/kigo_default.svgz 39a3989
> data/themes/kigo_plain.svgz 99a0dea
> src/game/stone.h 2702c6b
> src/game/stone.cpp a6d7b85
> src/gui/graphicsview/gamescene.cpp fb1ecfc
> src/gui/graphicsview/themerenderer.h b53da35
> src/gui/graphicsview/themerenderer.cpp 7411950
>
> Diff: https://git.reviewboard.kde.org/r/125506/diff/
>
>
> Testing
> -------
>
> playing.
>
>
> File Attachments
> ----------------
>
> kigo_default.svgz
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/03/cc6b8445-7fbc-4639-8210-68b22ef5659c__kigo_default.svgz
> kigo_plain.svgz
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/03/8acf715d-1502-43eb-a58b-8f4faff80c4c__kigo_plain.svgz
>
>
> Thanks,
>
> Michal Humpula
>
>
--===============0275360199124896203==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125506/">https://git.reviewboard.kde.org/r/125506/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On octubre 28th, 2015, 11:07 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Sascha hasn't done any commit since 2010, so this is \
one of the manu unmaintened stuff we have.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">If you really think \
this is a good thing, commit it (maybe wait a few more weeks in case anyone else \
bothers to comment)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Michal do you plan to commit this or what?</p></pre> <br />
<p>- Albert</p>
<br />
<p>On octubre 3rd, 2015, 2:45 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Games and Sascha Peilicke.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated oct. 3, 2015, 2:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kigo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Because there is no animation for move, it's not \
immediately clear where the oponent played. This patch adds a second stone type which \
is used for the last move.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">playing.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/themes/kigo_default.svgz <span style="color: grey">(39a3989)</span></li>
<li>data/themes/kigo_plain.svgz <span style="color: grey">(99a0dea)</span></li>
<li>src/game/stone.h <span style="color: grey">(2702c6b)</span></li>
<li>src/game/stone.cpp <span style="color: grey">(a6d7b85)</span></li>
<li>src/gui/graphicsview/gamescene.cpp <span style="color: \
grey">(fb1ecfc)</span></li>
<li>src/gui/graphicsview/themerenderer.h <span style="color: \
grey">(b53da35)</span></li>
<li>src/gui/graphicsview/themerenderer.cpp <span style="color: \
grey">(7411950)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125506/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/03/cc6b8445-7fbc-4639-8210-68b22ef5659c__kigo_default.svgz">kigo_default.svgz</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/03/8acf715d-1502-43eb-a58b-8f4faff80c4c__kigo_plain.svgz">kigo_plain.svgz</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0275360199124896203==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic