[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 126043: Hide the hint after the timeout
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2015-11-30 22:12:41
Message-ID: 20151130221241.29696.95138 () mimi ! kde ! org
[Download RAW message or body]
--===============0216595718134488588==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126043/#review88978
-----------------------------------------------------------
src/gui/graphicsview/gamescene.cpp (line 92)
<https://git.reviewboard.kde.org/r/126043/#comment60912>
I think you should use a real QTimer instead of ::singleShot, otherwise if you \
press the hint button a few times while the hint is still visible things start \
getting weird. That or disable the hint button while the hints are shown.
- Albert Astals Cid
On nov. 12, 2015, 1:28 p.m., Arseny Krasutsky wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126043/
> -----------------------------------------------------------
>
> (Updated nov. 12, 2015, 1:28 p.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: kigo
>
>
> Description
> -------
>
> Hide the hint after the timeout, use the time interval from the preferences, \
> hintVisibleTime()
>
> Diffs
> -----
>
> src/gui/graphicsview/gamescene.cpp fb1ecfc2fad5c36ba13a0b52e8b509c187ddfdb4
>
> Diff: https://git.reviewboard.kde.org/r/126043/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arseny Krasutsky
>
>
--===============0216595718134488588==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126043/">https://git.reviewboard.kde.org/r/126043/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126043/diff/1/?file=416636#file416636line92" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/gui/graphicsview/gamescene.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
GameScene::showLabels(bool show)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">92</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QTimer</span><span class="o">::</span><span \
class="n">singleShot</span><span class="p">(</span><span \
class="n">Preferences</span><span class="o">::</span><span \
class="n">hintVisibleTime</span><span class="p">()</span> <span class="o">*</span> \
<span class="mi">1000</span><span class="p">,</span> <span class="k">this</span><span \
class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span \
class="n">hideHint</span><span class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think you should use a real QTimer instead of ::singleShot, otherwise if you press \
the hint button a few times while the hint is still visible things start getting \
weird. That or disable the hint button while the hints are shown.</p></pre> </div>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On novembre 12th, 2015, 1:28 p.m. UTC, Arseny Krasutsky wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Arseny Krasutsky.</div>
<p style="color: grey;"><i>Updated nov. 12, 2015, 1:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kigo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hide the hint after the timeout, use the time interval \
from the preferences, hintVisibleTime()</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/gui/graphicsview/gamescene.cpp <span style="color: \
grey">(fb1ecfc2fad5c36ba13a0b52e8b509c187ddfdb4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126043/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0216595718134488588==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic