--===============2345173260855373967== Content-Type: multipart/alternative; boundary="===============1654555981185686538==" --===============1654555981185686538== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121653/#review72986 ----------------------------------------------------------- Ship it! Looks good, i'll commit it - Albert Astals Cid On des. 23, 2014, 8:28 p.m., Jan-Peter Nilsson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121653/ > ----------------------------------------------------------- > > (Updated des. 23, 2014, 8:28 p.m.) > > > Review request for KDE Games. > > > Repository: kmahjongg > > > Description > ------- > > This patch breaks out parts of updateSpriteMap to private methods in order to reduce code duplication between the different viewing angles. > > > Diffs > ----- > > boardwidget.h f1e0483 > boardwidget.cpp 04ba8c5 > > Diff: https://git.reviewboard.kde.org/r/121653/diff/ > > > Testing > ------- > > I have verified that the center tile of the default layout remain at the same position as with the original code for all four angles. > > > Thanks, > > Jan-Peter Nilsson > > --===============1654555981185686538== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121653/

Ship it!

Looks good, i'll commit it

- Albert Astals Cid

On desembre 23rd, 2014, 8:28 p.m. UTC, Jan-Peter Nilsson wrote:

Review request for KDE Games.

By Jan-Peter Nilsson.

Updated des. 23, 2014, 8:28 p.m.

Repository: kmahjongg

Description

This patch breaks out parts of updateSpriteMap to private methods in order to reduce code duplication between the different viewing angles.

Testing

I have verified that the center tile of the default layout remain at the same position as with the original code for all four angles.

Diffs

boardwidget.h (f1e0483)
boardwidget.cpp (04ba8c5)

View Diff

--===============1654555981185686538==-- --===============2345173260855373967== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-games-devel mailing list kde-games-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-games-devel --===============2345173260855373967==--