[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 114840: Play a fade-in animation to show the adversary's ships
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2014-01-03 21:02:56
Message-ID: 20140103210256.11840.17522 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114840/#review46728
-----------------------------------------------------------
src/controller.cpp
<https://git.reviewboard.kde.org/r/114840/#comment33349>
I did not miss that one. (the other one, yes, I missed it somehow).
I changed it to emit the gameOver to show the ships just after the game is over, \
not just after you press the messagebox saying "have better luck next time". But this \
is just a matter of taste. (Es cuestión de gustos)
- Jaime Torres Amate
On Jan. 3, 2014, 8:30 p.m., Roney Gomes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114840/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2014, 8:30 p.m.)
>
>
> Review request for KDE Games and Jaime Torres Amate.
>
>
> Repository: knavalbattle
>
>
> Description
> -------
>
> Enemy ships now appear in both single player and network mode, that's cool. \
> However, when I first started to work on this feature the ships appeared smoothly \
> on the table after the player pressed the "OK" button of the ending KMessageBox.
> As Jaime didn't work directly on the branch I set up he may have missed these two \
> lines of code.
>
> Diffs
> -----
>
> src/battlefieldview.cpp b682757
> src/controller.cpp df44ff4
>
> Diff: https://git.reviewboard.kde.org/r/114840/diff/
>
>
> Testing
> -------
>
> I've lost the game a few times in order to see the enemy ships appearing.
>
>
> Thanks,
>
> Roney Gomes
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114840/">https://git.reviewboard.kde.org/r/114840/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114840/diff/1/?file=229766#file229766line223" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/controller.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Controller::ready(int player)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">223</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">emit</span> <span class="n">gameOver</span><span class="p">(</span><span \
class="n">winner</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did not \
miss that one. (the other one, yes, I missed it somehow).
I changed it to emit the gameOver to show the ships just after the game is over, not \
just after you press the messagebox saying "have better luck next time". \
But this is just a matter of taste. (Es cuestión de gustos)</pre> </div>
<br />
<p>- Jaime Torres Amate</p>
<br />
<p>On January 3rd, 2014, 8:30 p.m. UTC, Roney Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games and Jaime Torres Amate.</div>
<div>By Roney Gomes.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2014, 8:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Enemy ships now appear in both single player and network mode, \
that's cool. However, when I first started to work on this feature the ships \
appeared smoothly on the table after the player pressed the "OK" button of \
the ending KMessageBox.
As Jaime didn't work directly on the branch I set up he may have missed these two \
lines of code.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've lost the game a few times in order to see the enemy ships \
appearing.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/battlefieldview.cpp <span style="color: grey">(b682757)</span></li>
<li>src/controller.cpp <span style="color: grey">(df44ff4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114840/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic