'Re: [Kde-games-devel] Review Request 114840: Play a fade-in animation to show the adversary's ships'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request 114840: Play a fade-in animation to show the adversary's ships
From:       "Roney Gomes" <roney477 () gmail ! com>
Date:       2014-01-03 20:30:42
Message-ID: 20140103203042.11858.95748 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114840/
-----------------------------------------------------------

(Updated Jan. 3, 2014, 8:30 p.m.)

Review request for KDE Games and Jaime Torres Amate.

Repository: knavalbattle

Description
-------

Enemy ships now appear in both single player and network mode, that's cool. However, \
when I first started to work on this feature the ships appeared smoothly on the table \
after the player pressed the "OK" button of the ending KMessageBox.

As Jaime didn't work directly on the branch I set up he may have missed these two \
lines of code.

Diffs
-----

  src/battlefieldview.cpp b682757 
  src/controller.cpp df44ff4 

Diff: https://git.reviewboard.kde.org/r/114840/diff/

Testing
-------

I've lost the game a few times in order to see the enemy ships appearing.

Thanks,

Roney Gomes

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114840/">https://git.reviewboard.kde.org/r/114840/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Games and Jaime Torres Amate.</div>
<div>By Roney Gomes.</div>

<p style="color: grey;"><i>Updated Jan. 3, 2014, 8:30 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Enemy ships now appear in both single player and network mode, \
that&#39;s cool. However, when I first started to work on this feature the ships \
appeared smoothly on the table after the player pressed the &quot;OK&quot; button of \
the ending KMessageBox.

As Jaime didn&#39;t work directly on the branch I set up he may have missed these two \
lines of code.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;ve lost the game a few times in order to see the enemy ships \
appearing.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/battlefieldview.cpp <span style="color: grey">(b682757)</span></li>

 <li>src/controller.cpp <span style="color: grey">(df44ff4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114840/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread] 