[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 108606: Add an option to change the row height
From: "Commit Hook" <null () kde ! org>
Date: 2013-02-10 22:21:48
Message-ID: 20130210222148.802.88740 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108606/#review27145
-----------------------------------------------------------
This review has been submitted with commit e457c3c4b5f745068f48b8a347877b43ae132835 \
by Albert Astals Cid on behalf of Ian Simpson to branch master.
- Commit Hook
On Jan. 29, 2013, 9:25 p.m., Ian Simpson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108606/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2013, 9:25 p.m.)
>
>
> Review request for KDE Games.
>
>
> Description
> -------
>
> Adds a configuration option to set the row height of the tableview.
>
> Would have liked to prevent the height being set smaller than the font size. I \
> tried to figure out how to get hold of the rowHeight spinbox in order to set its \
> minimum value to that of the font size when it was changed, but couldn't. Anyone \
> give me a hint? :-)
> Other than that it seems to work OK.
>
>
> This addresses bug 309428.
> http://bugs.kde.org/show_bug.cgi?id=309428
>
>
> Diffs
> -----
>
> src/itemdelegate.h PRE-CREATION
> src/configwidget.cpp 30851ae
> src/configwidget.h e35be7a
> src/configPage.ui 5382a33
> src/CMakeLists.txt 1a0f3a8
> src/itemdelegate.cpp PRE-CREATION
> src/kiriki.h 357b771
> src/kiriki.cpp 4571d8f
> src/kiriki.kcfg 785991a
>
> Diff: http://git.reviewboard.kde.org/r/108606/diff/
>
>
> Testing
> -------
>
> Simply played a few games, changing the font size and row height.
>
>
> Thanks,
>
> Ian Simpson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108606/">http://git.reviewboard.kde.org/r/108606/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit e457c3c4b5f745068f48b8a347877b43ae132835 by Albert Astals Cid \
on behalf of Ian Simpson to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On January 29th, 2013, 9:25 p.m. UTC, Ian Simpson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Ian Simpson.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2013, 9:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds a configuration option to set the row height of the tableview.
Would have liked to prevent the height being set smaller than the font size. I tried \
to figure out how to get hold of the rowHeight spinbox in order to set its minimum \
value to that of the font size when it was changed, but couldn't. Anyone give me \
a hint? :-)
Other than that it seems to work OK.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Simply played a few games, changing the font size and row height.</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=309428">309428</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/itemdelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/configwidget.cpp <span style="color: grey">(30851ae)</span></li>
<li>src/configwidget.h <span style="color: grey">(e35be7a)</span></li>
<li>src/configPage.ui <span style="color: grey">(5382a33)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(1a0f3a8)</span></li>
<li>src/itemdelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kiriki.h <span style="color: grey">(357b771)</span></li>
<li>src/kiriki.cpp <span style="color: grey">(4571d8f)</span></li>
<li>src/kiriki.kcfg <span style="color: grey">(785991a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108606/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic