[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request: Porting KBounce to KgSound
From: "Ian Wadham" <ianw2 () optusnet ! com ! au>
Date: 2012-08-16 4:37:16
Message-ID: 20120816043716.5065.90518 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 16, 2012, 4:31 a.m., Ian Wadham wrote:
> > Ship It!
I will commit this, with acknowledgements to Roney Gomes in the commit mess=
age. It could not be committed before because of a freeze on KDE Games trun=
k.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6930/#review10934
-----------------------------------------------------------
On April 27, 2012, 11:06 p.m., Roney Gomes wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6930/
> -----------------------------------------------------------
> =
> (Updated April 27, 2012, 11:06 p.m.)
> =
> =
> Review request for KDE Games.
> =
> =
> Description
> -------
> =
> The changed files were:
> - CMakeLists.txt
> - board.h
> - board.cpp
> - gamewidget.h
> - gamewidget.cpp
> - mainwindow.cpp
> - wall.h
> - wall.cpp
> =
> The class KBounceSound is no more necessary.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdegames/kbounce/CMakeLists.txt 1292134 =
> /trunk/KDE/kdegames/kbounce/board.h 1292134 =
> /trunk/KDE/kdegames/kbounce/board.cpp 1292134 =
> /trunk/KDE/kdegames/kbounce/gamewidget.h 1292134 =
> /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1292134 =
> /trunk/KDE/kdegames/kbounce/mainwindow.cpp 1292134 =
> /trunk/KDE/kdegames/kbounce/wall.h 1292134 =
> /trunk/KDE/kdegames/kbounce/wall.cpp 1292134 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6930/diff/
> =
> =
> Testing
> -------
> =
> I've played the game in the following conditions:
> - sounds enabled and running
> - sounds disable and running
> - paused, sounds disabled, and then running
> - paused, sounds enabled, and then running
> =
> I could not advance to the next levels because there is a commented block=
of code in the file that handles the main window. Since I don't know wheth=
er there's someone working on it, thought that would be better leave it the=
way it is. =
> =
> =
> Thanks,
> =
> Roney Gomes
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6930/">http://svn.reviewboard.kde.org/r/6930/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 16th, 2012, 4:31 a.m., <b>Ian Wadham</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship \
It!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I will commit this, with \
acknowledgements to Roney Gomes in the commit message. It could not be committed \
before because of a freeze on KDE Games trunk.</pre> <br />
<p>- Ian</p>
<br />
<p>On April 27th, 2012, 11:06 p.m., Roney Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Roney Gomes.</div>
<p style="color: grey;"><i>Updated April 27, 2012, 11:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The changed files were:
- CMakeLists.txt
- board.h
- board.cpp
- gamewidget.h
- gamewidget.cpp
- mainwindow.cpp
- wall.h
- wall.cpp
The class KBounceSound is no more necessary.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've played the game in the following conditions:
- sounds enabled and running
- sounds disable and running
- paused, sounds disabled, and then running
- paused, sounds enabled, and then running
I could not advance to the next levels because there is a commented block of code in \
the file that handles the main window. Since I don't know whether there's \
someone working on it, thought that would be better leave it the way it is. </pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/kbounce/CMakeLists.txt <span style="color: \
grey">(1292134)</span></li>
<li>/trunk/KDE/kdegames/kbounce/board.h <span style="color: \
grey">(1292134)</span></li>
<li>/trunk/KDE/kdegames/kbounce/board.cpp <span style="color: \
grey">(1292134)</span></li>
<li>/trunk/KDE/kdegames/kbounce/gamewidget.h <span style="color: \
grey">(1292134)</span></li>
<li>/trunk/KDE/kdegames/kbounce/gamewidget.cpp <span style="color: \
grey">(1292134)</span></li>
<li>/trunk/KDE/kdegames/kbounce/mainwindow.cpp <span style="color: \
grey">(1292134)</span></li>
<li>/trunk/KDE/kdegames/kbounce/wall.h <span style="color: \
grey">(1292134)</span></li>
<li>/trunk/KDE/kdegames/kbounce/wall.cpp <span style="color: \
grey">(1292134)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6930/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic