From kde-games-devel Thu Aug 16 04:37:16 2012 From: "Ian Wadham" Date: Thu, 16 Aug 2012 04:37:16 +0000 To: kde-games-devel Subject: Re: [Kde-games-devel] Review Request: Porting KBounce to KgSound Message-Id: <20120816043716.5065.90518 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-games-devel&m=134509185008242 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1312649492113229610==" --===============1312649492113229610== Content-Type: multipart/alternative; boundary="===============6990737375109074136==" --===============6990737375109074136== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 16, 2012, 4:31 a.m., Ian Wadham wrote: > > Ship It! I will commit this, with acknowledgements to Roney Gomes in the commit mess= age. It could not be committed before because of a freeze on KDE Games trun= k. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6930/#review10934 ----------------------------------------------------------- On April 27, 2012, 11:06 p.m., Roney Gomes wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6930/ > ----------------------------------------------------------- > = > (Updated April 27, 2012, 11:06 p.m.) > = > = > Review request for KDE Games. > = > = > Description > ------- > = > The changed files were: > - CMakeLists.txt > - board.h > - board.cpp > - gamewidget.h > - gamewidget.cpp > - mainwindow.cpp > - wall.h > - wall.cpp > = > The class KBounceSound is no more necessary. > = > = > Diffs > ----- > = > /trunk/KDE/kdegames/kbounce/CMakeLists.txt 1292134 = > /trunk/KDE/kdegames/kbounce/board.h 1292134 = > /trunk/KDE/kdegames/kbounce/board.cpp 1292134 = > /trunk/KDE/kdegames/kbounce/gamewidget.h 1292134 = > /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1292134 = > /trunk/KDE/kdegames/kbounce/mainwindow.cpp 1292134 = > /trunk/KDE/kdegames/kbounce/wall.h 1292134 = > /trunk/KDE/kdegames/kbounce/wall.cpp 1292134 = > = > Diff: http://svn.reviewboard.kde.org/r/6930/diff/ > = > = > Testing > ------- > = > I've played the game in the following conditions: > - sounds enabled and running > - sounds disable and running > - paused, sounds disabled, and then running > - paused, sounds enabled, and then running > = > I could not advance to the next levels because there is a commented block= of code in the file that handles the main window. Since I don't know wheth= er there's someone working on it, thought that would be better leave it the= way it is. = > = > = > Thanks, > = > Roney Gomes > = > --===============6990737375109074136== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6930/

On August 16th, 2012, 4:31 a.m., Ian Wadham= wrote:
Ship It!<=
/pre>
 

I will comm=
it this, with acknowledgements to Roney Gomes in the commit message. It cou=
ld not be committed before because of a freeze on KDE Games trunk.

- Ian

On April 27th, 2012, 11:06 p.m., Roney Gomes wrote:

Review request for KDE Games.

By Roney Gomes.

Updated April 27, 2012, 11:06 p.m.

Descripti= on

The changed files were:
- CMakeLists.txt
- board.h
- board.cpp
- gamewidget.h
- gamewidget.cpp
- mainwindow.cpp
- wall.h
- wall.cpp

The class KBounceSound is no more necessary.

Testing <= /h1>

I've played the game in the following conditions:
- sounds enabled and running
- sounds disable and running
- paused, sounds disabled, and then running
- paused, sounds enabled, and then running

I could not advance to the next levels because there is a commented block o=
f code in the file that handles the main window. Since I don't know whe=
ther there's someone working on it, thought that would be better leave =
it the way it is.

Diffs=

/trunk/KDE/kdegames/kbounce/CMakeLists.txt (1292134)
/trunk/KDE/kdegames/kbounce/board.h (12921= 34)
/trunk/KDE/kdegames/kbounce/board.cpp (129= 2134)
/trunk/KDE/kdegames/kbounce/gamewidget.h (= 1292134)
/trunk/KDE/kdegames/kbounce/gamewidget.cpp (1292134)
/trunk/KDE/kdegames/kbounce/mainwindow.cpp (1292134)
/trunk/KDE/kdegames/kbounce/wall.h (129213= 4)
/trunk/KDE/kdegames/kbounce/wall.cpp (1292= 134)

--===============6990737375109074136==-- --===============1312649492113229610== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-games-devel mailing list kde-games-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-games-devel --===============1312649492113229610==--