[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review request for Picmi
From: nihui <shuizhuyuanluo () 126 ! com>
Date: 2012-07-11 14:17:57
Message-ID: 2234144e.18e6d.13876674b4c.Coremail.shuizhuyuanluo () 126 ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
hi
first, thanks a lot for this magic logic game work.
problems I've found
some picmi codes have to be modified so that I can build picmi in kde 4.9 currently. \
(patch attached) fullscreen sometimes does not work properly through clicking the \
menu entry the widget layout of configuration dialog seems to be hardcoded, which \
makes troubles in different widget style(some widgets overlapped with each other) \
there is no toolbar in picmi, so the "configure toolbars" menu entry is useless in \
level selection dialog, all level names displays as "???"
regards,
nihui
At 2012-07-11 17:18:37,"Jakob Gruber" <jakob.gruber@gmail.com> wrote:
> Hi all,
>
> as you might have heard, I'd like to submit Picmi for inclusion into
> kdegames. I've gone through the application lifecycle rules, and apart
> from some krazy2 issues [1] (mostly false positives AFAIK) they should
> all be satisfied.
>
> The most significant new feature is 51 preset puzzles which actually
> turn into recognizable images once solved. Many of them are quite
> difficult and should keep players busy for a couple of evenings. Save
> states have also been added as some of the more challenging puzzles
> can require trial and error methods. As always, random puzzles are
> still included.
>
> Before I apply for transferring to KDE Review, I'd like to ask you for
> your feedback. Please check out the code, try out the game, let me
> know if there are any issues and I will do my best to resolve them.
> But most importantly, please give me your opinions on if you're having
> fun, and if you personally think Picmi would fit well into the current
> kdegames roster (or not).
>
> Albert has also mentioned the fear of disappearing maintainers. I
> can't do much more than assert once again that I have every intention
> of sticking around. I've been (re)writing Picmi since over two years
> (github.com/schuay/picmi) and I won't vanish when bug reports start
> popping up.
>
> Thanks in advance for your time,
> Jakob
>
> PS: git clone git://anongit.kde.org/picmi && cd picmi && make && build/src/picmi
> PPS: You will need to 'make install' to see the save state menu entries.
>
> [1] http://www.englishbreakfastnetwork.org/krazy/reports/playground/games/picmi/index.html
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel
[Attachment #5 (text/html)]
<div style="line-height:1.7;color:#000000;font-size:14px;font-family:arial">hi<br>first, \
thanks a lot for this magic logic game work.<br><br> problems I've found<br>some \
picmi codes have to be modified so that I can build picmi in kde 4.9 currently. \
(patch attached)<br> fullscreen sometimes does not work properly through clicking the \
menu entry<br> the widget layout of configuration dialog seems to be hardcoded, which \
makes troubles in different widget style(some widgets overlapped with each \
other)<br>there is no toolbar in picmi, so the "configure toolbars" menu entry is \
useless<br>in level selection dialog, all level names displays as \
"???"<br><br><br>regards,<br>nihui<br><div></div><div \
id="divNeteaseMailCard"></div><pre><br>At 2012-07-11 17:18:37,"Jakob Gruber" <jakob.gruber@gmail.com> wrote:
>Hi all,
>
>as you might have heard, I'd like to submit Picmi for inclusion into
>kdegames. I've gone through the application lifecycle rules, and apart
>from some krazy2 issues [1] (mostly false positives AFAIK) they should
>all be satisfied.
>
>The most significant new feature is 51 preset puzzles which actually
>turn into recognizable images once solved. Many of them are quite
>difficult and should keep players busy for a couple of evenings. Save
>states have also been added as some of the more challenging puzzles
>can require trial and error methods. As always, random puzzles are
>still included.
>
>Before I apply for transferring to KDE Review, I'd like to ask you for
>your feedback. Please check out the code, try out the game, let me
>know if there are any issues and I will do my best to resolve them.
>But most importantly, please give me your opinions on if you're having
>fun, and if you personally think Picmi would fit well into the current
>kdegames roster (or not).
>
>Albert has also mentioned the fear of disappearing maintainers. I
>can't do much more than assert once again that I have every intention
>of sticking around. I've been (re)writing Picmi since over two years
>(github.com/schuay/picmi) and I won't vanish when bug reports start
>popping up.
>
>Thanks in advance for your time,
>Jakob
>
>PS: git clone git://anongit.kde.org/picmi && cd picmi && make && build/src/picmi
>PPS: You will need to 'make install' to see the save state menu entries.
>
>[1] http://www.englishbreakfastnetwork.org/krazy/reports/playground/games/picmi/index.html
>_______________________________________________
>kde-games-devel mailing list
>kde-games-devel@kde.org
>https://mail.kde.org/mailman/listinfo/kde-games-devel
</pre></div>
["picmi.diff" (application/octet-stream)]
diff --git a/CMakeLists.txt b/CMakeLists.txt
index d9f1a18..f4c99f4 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -10,7 +10,7 @@ set(QT_USE_QTXML TRUE)
find_package(Qt4 REQUIRED)
find_package(KDE4 REQUIRED)
-find_package(LibKDEGames REQUIRED)
+find_package(KDEGames REQUIRED)
add_subdirectory(themes)
add_subdirectory(icons)
diff --git a/src/gui/mainwindow.h b/src/gui/mainwindow.h
index 6c3f626..8b8bdc4 100644
--- a/src/gui/mainwindow.h
+++ b/src/gui/mainwindow.h
@@ -25,13 +25,14 @@
#include <ktoggleaction.h>
#include <kxmlguiwindow.h>
+#include "config.h"
+
#ifdef HAVE_KGDIFFICULTY
#include <kgdifficulty.h>
#else
#include <kgamedifficulty.h>
#endif
-#include "config.h"
#include "scene.h"
#include "src/logic/picmi.h"
#include "view.h"
diff --git a/src/settings.h b/src/settings.h
index c13733f..1a783a3 100644
--- a/src/settings.h
+++ b/src/settings.h
@@ -23,14 +23,14 @@
#include <QVector>
#include <memory>
+#include "config.h"
+
#ifdef HAVE_KGDIFFICULTY
#include <kgdifficulty.h>
#else
#include <kgamedifficulty.h>
#endif
-#include "config.h"
-
class Settings
{
public:
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic